fix(web): raise month picker day contrast in dark theme - #3427
Merged
Conversation
Sidebar days inherited react-datepicker's black text, which met contrast on Light Beach and failed on Dark Abyss. Paint unselected numbers with theme text and cover both themes in the datepicker a11y check. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
September 5, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The sidebar month picker painted unselected day numbers as inherited black (
color: inheritfrom react-datepicker's#000). That met contrast on Light Beach and failed on Dark Abyss, where the numbers sat on the near-black sidebar. Unselected days and weekday labels now use theme text (--text/--text-muted). The selected week capsule still uses--on-accenton--accent.The datepicker contrast e2e now runs in both themes so this cannot regress on dark only.
Verify
VERDICT: PASSChecks run:
test:web,type-check,lint,knip,test:a11y,test:e2e