KC-1361: Reject share commands that target a record or folder owner#2235
Merged
Conversation
Fail early with a clear message for share-record, share-folder, nsf-share-record, and nsf-share-folder so owners are not granted, updated, or revoked as if they were share recipients.
sali-ks
approved these changes
Jul 22, 2026
sali-ks
reviewed
Jul 22, 2026
| owner_username = shared_folder.get('owner_username') or '' | ||
| if owner_username and owner_username.casefold() == email_cf: | ||
| return True | ||
| # Some sync payloads also put an owner flag on the user row. |
Contributor
There was a problem hiding this comment.
Avoid the explicit for loop and continue.
Short-circuit as soon as a matching owner is found. Return False automatically if no matching user exists.
You can refactor with any()
users = shared_folder.get("users", [])
return any(
user.get("owner") is True
and (user.get("username") or "").casefold() == email_cf
for user in users
)
sali-ks
reviewed
Jul 22, 2026
| continue | ||
| if access.get('owner'): | ||
| return access.get('accessor_name') or '' | ||
| return '' |
Contributor
There was a problem hiding this comment.
You can use next() with a generator expression to make this more concise while preserving the behavior
return next(
(
access.get("accessor_name") or ""
for access in access_result.get("record_accesses", [])
if access.get("record_uid") == record_uid and access.get("owner")
),
"",
)
| username = accessor.get('username') | ||
| if username and username != params.user: | ||
| if is_nested_share_folder_owner_email(params, folder_uid, username): | ||
| continue |
Contributor
There was a problem hiding this comment.
wouldn't logging a info or warning that owner is skipped from sharing be better
| username = a.get('username') | ||
| if username and username != params.user: | ||
| if is_nested_share_folder_owner_email(params, folder_uid, username): | ||
| continue |
Contributor
There was a problem hiding this comment.
wouldn't logging a info or warning that owner is skipped from sharing be better
| owner = find_record_owner_username(access_result, record_uid) | ||
| if not owner or owner.casefold() != email.casefold(): | ||
| return | ||
| if allow_owner_transfer: |
Contributor
There was a problem hiding this comment.
please change this variable name for better readibility, this is confusing
adeshmukh-ks
approved these changes
Jul 23, 2026
pvagare-ks
approved these changes
Jul 23, 2026
sshrushanth-ks
added a commit
that referenced
this pull request
Jul 23, 2026
…2235) * Reject share commands that target a record or folder owner. Fail early with a clear message for share-record, share-folder, nsf-share-record, and nsf-share-folder so owners are not granted, updated, or revoked as if they were share recipients. * resolved review comments * addressed logging and variable naming comments
sk-keeper
pushed a commit
that referenced
this pull request
Jul 23, 2026
…2235) * Reject share commands that target a record or folder owner. Fail early with a clear message for share-record, share-folder, nsf-share-record, and nsf-share-folder so owners are not granted, updated, or revoked as if they were share recipients. * resolved review comments * addressed logging and variable naming comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sharing a record or folder to its owner via share-record, share-folder, nsf-share-record, or nsf-share-folder treated the owner like a normal share recipient. Grant, update, and revoke against the owner are invalid because the owner already has full access. These commands now detect that case early and fail with a clear message instead of sending a confusing or no-op share request. Ownership transfer (share-record -a owner) still works, but transferring to someone who already owns the record is rejected as a no-op.
Changes