Added support for PAM Config Command in DotNet SDK and CLI.#516
Open
amandli-ks wants to merge 11 commits into
Open
Added support for PAM Config Command in DotNet SDK and CLI.#516amandli-ks wants to merge 11 commits into
amandli-ks wants to merge 11 commits into
Conversation
amandli-ks
requested review from
adeshmukh-ks,
kpande-ks,
sali-ks and
sgaddala-ks
July 13, 2026 13:01
sali-ks
reviewed
Jul 15, 2026
sali-ks
reviewed
Jul 15, 2026
sali-ks
reviewed
Jul 15, 2026
| return null; | ||
| } | ||
|
|
||
| var allowed = allowedTypes == null |
There was a problem hiding this comment.
you can refactor like
var allowed = allowedTypes?.ToHashSet(StringComparer.Ordinal);
Contributor
Author
There was a problem hiding this comment.
ToHashSet() is not available in netstandard2.0
sali-ks
reviewed
Jul 15, 2026
|
|
||
| if (TryGetTypedRecord(vault, identifier, out var typedByUid)) | ||
| { | ||
| if (allowedTypes == null || allowedTypes.Contains(typedByUid.TypeName ?? "")) |
There was a problem hiding this comment.
.Contains(typedByUid.TypeName ?? "")), use string.Empty
sali-ks
reviewed
Jul 15, 2026
sali-ks
approved these changes
Jul 21, 2026
sgaddala-ks
approved these changes
Jul 23, 2026
adeshmukh-ks
requested changes
Jul 24, 2026
adeshmukh-ks
left a comment
adeshmukh-ks
left a comment
There was a problem hiding this comment.
Need to discuss DAG implementation changes, please make other changes as discussed
| public static async Task SetConfigurationControllerAsync( | ||
| IAuthentication auth, | ||
| string configurationUid, | ||
| string controllerUid) |
There was a problem hiding this comment.
if this is a user facing function, name this to gatewayuid instead of controlleruid to avoid confusion
…ty/keeper-sdk-dotnet into sdk-pam-config-dev
amandli-ks
changed the base branch from
sdk-pam-config-rel
to
sdk-pam-config-release
July 27, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.