Added support for Enterprise role and node commands#215
Open
sgaddala-ks wants to merge 2 commits into
Open
Conversation
sgaddala-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
July 20, 2026 15:23
|
|
||
| export type NodeEditRequest = { | ||
| node_id: number | ||
| parent_id?: number |
Contributor
There was a problem hiding this comment.
| storage?: KeyStorage, | ||
| canExport?: boolean | ||
| ): Promise<void> { | ||
| const key = await this.importPrivateKeyEC(privateKey, publicKey) |
Contributor
There was a problem hiding this comment.
It looks like this new canExport param isn't actually passed through to importPrivateKeyEC, so technically this doesn't add anything, it'll always create extractable CryptoKeys as is. So should either undo this, or pipe the value through to the import private EC function to respect user intent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.