Skip to content

Add NSF support for pam rotation script list/add/edit/delete#213

Open
mtyagi-ks wants to merge 2 commits into
pam-nsf-support-intfrom
pam-rotation-script-nsf-support-int
Open

Add NSF support for pam rotation script list/add/edit/delete#213
mtyagi-ks wants to merge 2 commits into
pam-nsf-support-intfrom
pam-rotation-script-nsf-support-int

Conversation

@mtyagi-ks

Copy link
Copy Markdown
Contributor

Summary

  • Enable pam rotation script (list/add/edit/delete) for pamUser/pamDirectory records in Nested Shared Folders.
  • Add update_nsf_typed_record so NSF updates can add/remove record links for script file attachments.
  • Include script.fileRef in typed-record ref extraction so classic and NSF script updates keep file links in sync.

Test plan

  • pam rotation script add --script <file> <nsf-pamUser-uid> uploads and attaches the script
  • pam rotation script list <nsf-pamUser-uid> shows script UID/name/command
  • pam rotation script edit --script <uid|name> --script-command "..." <nsf-pamUser-uid> persists command
  • pam rotation script delete --script <uid|name> <nsf-pamUser-uid> removes the script
  • Classic (non-NSF) script commands still work
  • Depends on / stacks on pam-nsf-support-int

@sali-ks
sali-ks requested review from adeshmukh-ks and sali-ks July 22, 2026 06:27
@adeshmukh-ks
adeshmukh-ks changed the base branch from pam-rotation-script-nsf-support to pam-nsf-support-int July 22, 2026 10:35
"""Update an NSF typed record, including record-link adds/removes for file/script refs.

Mirrors classic ``record_management.update_record`` so PAM rotation scripts
(and other fileRef/script attachments) work on Keeper Drive records.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove keeper drive comment and remove comment start, instead of mirrors we can right that it is in sync with update record flow for classic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed



def update_nsf_typed_record(
vault: VaultOnline,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't an existing method? also if it is a new implementation we can add batch support to it like batch record add

@mtyagi-ks mtyagi-ks Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s intentionally new to mirror classic update_record for NSF typed records + links; batch can be a follow-up since the current caller is single-record and classic update is also single-record.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is NSF equivalent of classic update_record for TypedRecord + links
update_nsf_record (existing) is Dict/field update of NSF payload only — no record_links_add / remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants