add rbi edit and connection edit support for nsf#217
Open
mtyagi-ks wants to merge 2 commits into
Open
Conversation
|
|
||
| def _load_typed_record( | ||
| vault: vault_online.VaultOnline, | ||
| context: KeeperParams, |
Contributor
There was a problem hiding this comment.
if you are passing context, don't pass vault as it is present in context and can be fetched from it, or resolve methods to work with vault if context is not mandatory
|
|
||
|
|
||
| def _resolve_nsf_record_uid(vault: vault_online.VaultOnline, identifier: str) -> Optional[str]: | ||
| """Resolve an NSF record UID from a UID or exact title.""" |
Contributor
There was a problem hiding this comment.
these common methods can be moved to another file line pam_utils for reuse in all pamm files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pam rbi editandpam connection editso Nested Shared Folder PAM records work the same as classic vault records.nsf_management.update_nsf_record+extract_typed_record_data(aligned withpam config).-cfor NSF configs when DAG discovery alone is not enough.Test plan
pam connection edit <nsf-rbi-uid> -c <nsf-config-uid>succeeds and prints rotation/tunnel settingspam rbi edit -r <nsf-rbi-uid> -c <nsf-config-uid> --remote-browser-isolation on --connections-recording onnsf-get <nsf-rbi-uid>shows updatedpamRemoteBrowserSettings/ seed as expected