fix(ci): update golangci-lint config and regenerate docs#4
Merged
Conversation
- Move exclude-rules to linters.exclusions.rules (golangci-lint v2.11+) - Regenerate docs to include kh_update command - Add missing cobra/doc dependency for docs generation
- gosimple merged into staticcheck in golangci-lint v2, no longer valid - docs-check: cd docs broke git diff path; use go generate ./docs/ instead
These return values are universally ignored in CLI code -- writing to stdout/stderr and closing HTTP response bodies.
Previous config used default:standard which pulled in revive and gofmt checks the codebase was never written against. Start with core linters (errcheck, govet, staticcheck, unused, ineffassign) and add more later.
- Remove unused validConfigKeys var - Fix ineffectual assignment in pause_test.go - Lowercase error strings per Go convention (ST1005) - Remove trailing punctuation from error strings - Replace deprecated cobra.ExactValidArgs with MatchAll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan