Fix the media process lifecycle and the critical validation outcome - #1
Conversation
The three fixes on this branch are user visible: a critical validation now fails the file, a stopped run is reported as timeout or cancellation according to what actually happened, and the release script no longer falls back to a stale default version.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5de3c35241
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Changelog | ||
|
|
||
| ## 0.17.0 - 2026-06-13 | ||
| ## Unreleased |
There was a problem hiding this comment.
Preserve the released 0.17.0 changelog section
Replacing the 0.17.0 heading with Unreleased removes that released version from the changelog and incorrectly groups its existing update-check and drag-and-drop entries with the new fixes. Add a separate Unreleased section above the original ## 0.17.0 - 2026-06-13 heading so the published release history remains accurate.
Useful? React with 👍 / 👎.
Three fixes around the processing pipeline, plus the changelog entry that was missing for them.
Fixed
ValidateAsyncreturnedResult.Successfor every report it managed to build, including one withAudioComparisonStatus.Critical. The affected file counted as exported successfully and only produced a warning line. It now fails the item, with the report still attached so the findings stay visible in the validation panel.Changed
scripts/package-release.ps1requires an explicit-Versioninmajor.minor.patchform. The previous default was a stale0.2.0, so a forgotten argument silently produced a mislabelled package.release.ymlalways passes the value explicitly and is unaffected.Verification
Release builds carry
TreatWarningsAsErrors, so the build is the real gate here.