Skip to content

Fix the media process lifecycle and the critical validation outcome - #1

Merged
Kentarohakase merged 4 commits into
mainfrom
codex/fix-audio-pipeline-lifecycle
Aug 12, 2026
Merged

Fix the media process lifecycle and the critical validation outcome#1
Kentarohakase merged 4 commits into
mainfrom
codex/fix-audio-pipeline-lifecycle

Conversation

@Kentarohakase

Copy link
Copy Markdown
Owner

Three fixes around the processing pipeline, plus the changelog entry that was missing for them.

Fixed

  • A critical result validation reported success. ValidateAsync returned Result.Success for every report it managed to build, including one with AudioComparisonStatus.Critical. The affected file counted as exported successfully and only produced a warning line. It now fails the item, with the report still attached so the findings stay visible in the validation panel.
  • A stopped run was misreported. The inactivity watchdog only set a flag; the wait for the process kept running until the user cancelled, and the result was then labelled a cancellation. A timeout now ends the wait directly through a linked token and is reported as a timeout, while only an actual cancellation is reported as one.
  • Output was read while it was still being written. After a kill the app now waits briefly for the process to exit, stops the output readers, and reads the captured buffers under a lock. The watchdog also no longer tries to kill a process that has already exited.

Changed

  • scripts/package-release.ps1 requires an explicit -Version in major.minor.patch form. The previous default was a stale 0.2.0, so a forgotten argument silently produced a mislabelled package. release.yml always passes the value explicitly and is unaffected.

Verification

dotnet format .\AudioQualityEnhancer.slnx --verify-no-changes   -> clean
dotnet build  .\AudioQualityEnhancer.slnx -c Release            -> 0 warnings, 0 errors
dotnet test   .\AudioQualityEnhancer.slnx -c Release            -> 195 passed, 0 failed

Release builds carry TreatWarningsAsErrors, so the build is the real gate here.

The three fixes on this branch are user visible: a critical validation
now fails the file, a stopped run is reported as timeout or cancellation
according to what actually happened, and the release script no longer
falls back to a stale default version.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5de3c35241

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md
# Changelog

## 0.17.0 - 2026-06-13
## Unreleased

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the released 0.17.0 changelog section

Replacing the 0.17.0 heading with Unreleased removes that released version from the changelog and incorrectly groups its existing update-check and drag-and-drop entries with the new fixes. Add a separate Unreleased section above the original ## 0.17.0 - 2026-06-13 heading so the published release history remains accurate.

Useful? React with 👍 / 👎.

@Kentarohakase
Kentarohakase merged commit 89a4d33 into main Aug 12, 2026
1 check passed
@Kentarohakase
Kentarohakase deleted the codex/fix-audio-pipeline-lifecycle branch August 12, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant