Share the build settings, enforce warnings everywhere, measure coverage

.github/workflows/ci.yml

@@ -27,4 +27,12 @@ jobs:
         run: dotnet build .\AudioQualityEnhancer.slnx -c Release
 
       - name: Test
-        run: dotnet test .\AudioQualityEnhancer.slnx -c Release --no-build
+        run: dotnet test .\AudioQualityEnhancer.slnx -c Release --no-build --collect:"XPlat Code Coverage" --results-directory TestResults
+
+      - name: Upload coverage
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: coverage
+          path: TestResults\**\coverage.cobertura.xml
+          if-no-files-found: error

AudioQualityEnhancer.Tests/AudioQualityEnhancer.Tests.csproj

@@ -1,9 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+  <!-- Shared settings live in Directory.Build.props. -->
   <PropertyGroup>
-    <TargetFramework>net10.0-windows</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

AudioQualityEnhancer.csproj

@@ -1,23 +1,15 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+  <!-- Shared settings live in Directory.Build.props. -->
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
-    <TargetFramework>net10.0-windows</TargetFramework>
-    <Nullable>enable</Nullable>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <AnalysisLevel>latest</AnalysisLevel>
-    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <ApplicationManifest>app.manifest</ApplicationManifest>
     <UseWPF>true</UseWPF>
     <UseWindowsForms>true</UseWindowsForms>
     <!-- Keep in sync with the release tag when stamping a new version. -->
     <Version>0.17.0</Version>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="AudioQualityEnhancer.Tests\**\*" />
     <Compile Remove="Temp\**\*" />

Directory.Build.props

@@ -0,0 +1,25 @@
+<Project>
+
+  <PropertyGroup>
+    <TargetFramework>net10.0-windows</TargetFramework>
+    <Nullable>enable</Nullable>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <AnalysisLevel>latest</AnalysisLevel>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!--
+      Warnings are errors in every configuration, not only in Release. The build used to
+      accept them locally and reject them in CI, so a warning was found after the push
+      instead of before it. Both projects are warning free, so this costs nothing today.
+
+      AnalysisMode is deliberately left at its default. Raising it to Recommended surfaces
+      about 300 analyzer warnings and All about 1100, mostly CA1305, CA1822, CA2007 and
+      CA1515. That is a cleanup of its own and must not be smuggled in through a build
+      file, where it would simply block every later change.
+    -->
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
+
+</Project>

global.json

@@ -0,0 +1,6 @@
+{
+  "sdk": {
+    "version": "10.0.100",
+    "rollForward": "latestFeature"
+  }
+}