You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks really good.
I just have two requests.
First one is to implement the preview for custom earthkek as well.
Second one is to make the stone preview look more like they'll do when placed. That means they should also have the bigger stone images and should change their image when they are near cliffs.
I know second one is a bit more difficult but I'm sure you can do it.
I'm not sure the bigger stone images are possible because they depend on the surrounding rocks and may require a full recalculation of a broader part of the map.
It doesn't have to be exact.
We can just not calculate the surrounding stones in at all. But depending on the brush size the rocks inside the brush which is also what I thought of with custom earthkeks.
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (ring >= 1) image_id+=29;
elseimage_id+=24;
if (ring >= 1) {
image_id+=29;
} else {
image_id+=24;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.