FIX: (#1669) Fix handling emptying granaries and warehouses in request dispatch#1725
Open
n-aswin wants to merge 2 commits intoKeriew:masterfrom
Open
FIX: (#1669) Fix handling emptying granaries and warehouses in request dispatch#1725n-aswin wants to merge 2 commits intoKeriew:masterfrom
n-aswin wants to merge 2 commits intoKeriew:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: #1669
Emptying warehouses contribute to total available amount of resource in
city_resource_get_amount_for_request()throughbuilding_warehouses_count_available_resource()but were not handled when removing resource inbuilding_warehouses_send_resources_to_rome()while dispatch.Fixed by including emptying warehouses among the first warehouses considered to remove the resource.
Emptying granaries have been updated with the same logic.