font creator and embedded app - #51
Open
dmytrokirtoka wants to merge 2 commits into
Open
dmytrokirtoka wants to merge 2 commits into
dmytrokirtoka wants to merge 2 commits into
Conversation
dmytrokirtoka
force-pushed
the
ssd1306_base1
branch
from
December 25, 2017 14:49
f506f73 to
7b91d34
Compare
dmytrokirtoka
force-pushed
the
ssd1306_base1
branch
from
January 8, 2018 13:51
7b91d34 to
b4607d2
Compare
Collaborator
|
I believe this PR doesn't require review from our side :) Also I'm not sure about idea of storing binaries (ssd1306/my_app.odp). |
app grab data from mpu6050 dev and draw it to i2c_ssd1306 lcd dev
use case:
setup truetype2 lib, build crfont,
exec:
<fontcreator truetype/dejavu/DejaVuSansMono.ttf 12x12.fnt ascii.txt>
by now create only 12x12 font
build embedded app axis_to_lcd.c
arm-linux-gnueabihf-gcc axis_to_lcd.c -o accel2lcd
copy to device /root:
accel2lcd - embedded exe
12x12.fnt - embedded my font file
exec on device:
/root/accel2lcd /dev/mpu6050_0 /dev/fb1 /root/12x12.fnt
modules can be loaded on device before.
Signed-off-by: dmytro.kirtoka <dimk334@gmail.com>
dmytrokirtoka
force-pushed
the
ssd1306_base1
branch
from
January 10, 2018 16:33
b4607d2 to
4b5c543
Compare
Author
|
eliminated comments |
AleksandrBulyshchenko
left a comment
AleksandrBulyshchenko
left a comment
Collaborator
There was a problem hiding this comment.
👍
Some comments from my side:
- I believe text rendering functions and all operations with font should be moved out of
axis_to_lcd.c - It should be unified with
crfont.c- at least common header with data types - Preferably - build common library with font processing which is used by both - host for bitmap binary generation and target for text rendering.
|
|
||
| printf("%s: x: %d, y: %d, text: %s, img: %p\n", __FUNCTION__, x, y, text, img); | ||
|
|
||
| for (i = 0, shift_x = 0; i < strlen(text); ++i) { |
Collaborator
There was a problem hiding this comment.
here and above strlen() is called in a loop
|
|
||
| static int get_symbol_offset(char c) | ||
| { | ||
| return (c < '!' || c > 127) ? 0 : c - '!'; |
Collaborator
There was a problem hiding this comment.
You hardcode characters to bitmaps mapping here,
but use free order (defined by ascii.txt) when bitmaps are generated.
This is errors prone - either symbols' table should be embed into generated font file,
or it should be hardcodded for crfont.c as well (in common header).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added font creator program, embedded app and char map file
crfont.c create simple raster font (internal format) from freetype fonts
axis_to_lcd.c grab data from mpu6050 dev and draw it to i2c_ssd1306 lcd dev
use case:
setup truetype2 lib, build crfont,
exec:
<fontcreator truetype/dejavu/DejaVuSansMono.ttf 12x12.fnt ascii.txt>
by now create only 12x12 font
build embedded app axis_to_lcd.c
arm-linux-gnueabihf-gcc axis_to_lcd.c -o accel2lcd
copy to device /root:
accel2lcd - embedded exe
12x12.fnt - embedded my font file
exec on device:
/root/accel2lcd /dev/mpu6050_0 /dev/fb1 /root/12x12.fnt
modules can be loaded on device before.