Skip to content

Practice_II_Display: Add lcd driver - #162

Open
BekirovBekir wants to merge 2 commits into
Kernel-GL-HRK:Bekir.Bekirovfrom
BekirovBekir:practice_lcd
Open

BekirovBekir wants to merge 2 commits into
Kernel-GL-HRK:Bekir.Bekirovfrom
BekirovBekir:practice_lcd

Conversation

@BekirovBekir

Copy link
Copy Markdown

The device_tree_overlay directory contains overlay for the lcd that connected to the spi0 bus.
The driver is created two files into a sysfs:

  1. lcd_st7735s/fill_screen - fills whole screen with color (e.g. echo 0xf800 > /sys/class/lcd_st7735s/fill_screen)
  2. lcd_st7735s/fill_rect - fills rectangular area with color (e.g. echo "0x03e0 30 30 50 50" > /sys/class/lcd_st7735s/fill_rect).

@BekirovBekir BekirovBekir added the ready The PR is ready for review (set by author). label Jan 12, 2020
Comment thread Practice_02-display/lcd_driver/lcd_driver.c Outdated
@yekovalyov

Copy link
Copy Markdown
Contributor

Is the framebuffer interface implemented by this code?

@yekovalyov yekovalyov added changes requested The PR review revealed issues which should be fixed (set by reviewer) and removed ready The PR is ready for review (set by author). labels Jan 13, 2020
Signed-off-by: Bekir <bekirbekirov1986@gmail.com>
@BekirovBekir BekirovBekir added ready The PR is ready for review (set by author). and removed changes requested The PR review revealed issues which should be fixed (set by reviewer) labels Jan 14, 2020
Comment thread Practice_02-display/lcd_driver/fb_lcd.c Outdated
@yekovalyov

Copy link
Copy Markdown
Contributor

Please remove binary files like Practice_02-display/user_space_test_program/fbtest from repository.

Comment thread Practice_02-display/user_space_test_program/main.c
@BekirovBekir
BekirovBekir force-pushed the practice_lcd branch 3 times, most recently from 0a7fb8a to 8473580 Compare January 14, 2020 22:41
Comment thread Practice_02-display/lcd_driver/fb_lcd.h Outdated
Comment thread Practice_02-display/lcd_driver/fb_lcd.h Outdated
Comment thread Practice_02-display/lcd_driver/lcd_driver.c Outdated
Signed-off-by: Bekir <bekirbekirov1986@gmail.com>
@BekirovBekir

Copy link
Copy Markdown
Author

The fixes related to recent comments have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready The PR is ready for review (set by author).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants