Repository navigation
research: fix repeat sample manifest projection - #154
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the first manual
research-repeat-v1execution failure without changing thefrozen pilot v1 evidence or the repeat sample.
Failed run
35443831085804c021ddc47a1d6b479a70690af4032c8dd79db10585281049b32ca592c79a01f4c70cf0d85607dfe07a0efe23deddee4dd817187483ac02faThe workflow successfully materialized the frozen inputs and the three command
mode tuples completed stably, but every libbpf-backed tuple failed before VM
execution.
The repeat runner creates a one-profile matrix for each sampled tuple. Frozen
v1 libbpf manifests intentionally list all ten study profiles under
required_profiles. BPFCompat correctly rejects a matrix that omits anymanifest-required profile, so those sampled runs exited before producing a
report:
The failed staging run therefore observed only 9/21 planned repeats. Its 9
completed command-mode observations are diagnostic only; the run is not promoted
as repeat-study evidence.
Fix
For libbpf-backed repeat tuples only:
research/corpus/v1/study-plan.json;is narrowing
required_profilesto the sampled profile;This does not rewrite the frozen corpus manifest. It adapts only its matrix
membership assertion for a purposefully sampled single-profile rerun.
Regression coverage
The repeat preflight now:
plan;
After merge
Dispatch the repeat workflow again from
main:Only a complete post-fix run should be considered for the repeat-stability
dataset.