Remove the page-wide outline from the route focus target - #506
Merged
Merged
Conversation
Safari outlines the shared main landmark when navigation or a skip link focuses it, producing blue lines down both sides of the page. Suppress only that non-interactive landmark outline while preserving focus and scroll behavior and the visible focus indicators on actual controls. Extend the navigation regression to verify computed focus styles and use Option+Tab when testing link traversal in macOS WebKit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Fix the blue lines surrounding the full page after navigation, as reported in the VPS overview screenshot. Route changes and the skip link focus the shared
<main>landmark; Safari can paint its default outline around the entire content area.Suppress the outline only on that non-interactive landmark. Keep
tabIndex, route focus, scroll behavior, the skip link and the focus rings on actual controls intact. The existing navigation regression now checks the computed main outline and visible skip-link/input focus indicators, including macOS WebKit's Option+Tab navigation.Validation: navigation regression PASS 3/3 (Chromium desktop/mobile and WebKit); existing focus unit tests PASS 9/9; typecheck, lint and build PASS. The same WebKit assertion fails on unmodified main (
outline-style: auto) and passes with the fix (none). Browser results and the baseline reproduction are recorded in the task evidence. Uses synthetic API fixtures; no deployment or real-data changes. Independent of the other open UI PRs.Česky
Oprava modrého orámování celého obsahu ze screenshotu přehledu VPS. Při navigaci se fokus přesouvá na hlavní obsah a Safari kolem něj vykreslí výchozí obrys. Potlačení je omezené pouze na tento neinteraktivní blok.
Přesun fokusu, odkaz pro přeskočení navigace, pozice při návratu i zvýraznění polí a tlačítek zůstávají zachované. Ověřeno existujícími testy navigace a fokusu, včetně WebKitu. Pouze lokální testovací data; bez nasazení. PR je nezávislé na ostatních otevřených úpravách UI.