feat: multi-tenant Phase 4 — context-tagged event producer - #56
Merged
Merged
Conversation
…ibling file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ve e2e Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds the CDP→
BrowserEventproducer the audit found missing (events were drained and discarded). Per-tab listeners forward to a suppliedEventBus, so a session giving its own bus gets only its own tab's events — structural per-session isolation.ras-cdp::event_pump::attach(page, target, bus): armsEventFrameNavigated(main frame →NavigationCompleted) +EventJavascriptDialogOpening(→DialogOpened) listeners.BrowserPort::attach_events(target, bus)(default no-op; adapter resolves the Page and attaches).chromiumoxide_adapter_setup.rs) to stay under the 200-LOC cap.Test Plan
cargo build --workspace+ clippy clean; hooks green.#[ignore]+CDP_URL, Chrome 148):navigation_event_reaches_the_bus— 1 passed (NavigationCompleted delivered to the bus for the tab).Scope
Navigation + dialog events now; downloads/network/target-lifecycle are incremental on the same per-tab→bus model.
🤖 Generated with Claude Code