tweaks - #28
Merged
Merged
tweaks#28
Conversation
Randalphwa
commented
Mar 31, 2026
Randalphwa
commented
Member
- Add support for sccache
- Switch to #pragma once instead of conditional guards
- Remove unused header
- Remove duplicate compiler check
- Change variable names, replace magic numbers for clarity
Every compiler that supports C++23 supports #pragma once — GCC, Clang, MSVC, and Intel have all supported it for well over a decade.
Check is in version.h
Added /wd4018 alongside the existing /wd4307 in the MSVC test compile options. This suppresses the signed/unsigned warning from MSVC's system headers while leaving all other diagnostics intact.
Root cause: On Windows, std::abort() triggers two things that hang headless CI: CRT abort message box — a dialog requesting user input Windows Error Reporting (Watson/WER) — attempts to phone home and/or show a crash dialog The SIGABRT signal handler never fires because MSVC's abort() hits the dialog first. Fixes in no_exceptions.cpp: _set_abort_behavior(0, _WRITE_ABORT_MSG | _CALL_REPORTFAULT) — suppresses both the CRT dialog and WER, letting abort() proceed cleanly to the signal handler _CrtSetReportMode(_CRT_ASSERT/_CRT_ERROR, _CRTDBG_MODE_DEBUG) — redirects any Debug CRT assertions to the debugger (no-op in CI) instead of popping dialogs
Added TIMEOUT 10 to the test properties — if anything still hangs on any platform, CTest will kill it after 10 seconds instead of blocking forever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.