Skip to content

BOM support in textfile::ReadFile causing CodeQL warning #272

Description

Description:

Adding the BOM support has resulted in a securiy alert form CodeQL because of the conversion from a char* to a wchar_t*. In this particular case it is correct, but CodeQL doesn't know that. The safe workaround would be to create a special version of utf16to8 that takes a std::string_view instead of a wstring_view.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions