Add per-item conditional property to gate generated code - #1855
Merged
Merged
Conversation
This is under the Platorms property, and can be used in addition to the 3 platform checkboxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Platform checks in wxUiEditor only covered Windows/Unix/Mac. This PR allows the dev to also use a conditional in addition to the platform checks. E.g., you can now add something like 'MY_FEATURE_ENABLED' and the to prevent compiling or using the generated code unless condition is true (in addition to the selected platforms being true).
Changes
conditionalstring prop (prop_conditional) on widgets/windows. Empty by default; when set it gets AND-ed into the platform check during code generation. Defined in interfaces.xml and registered in the enum/help maps so it round-trips and is undoable.Closes #1557