internal project file - #1856
Merged
Merged
Conversation
There's really no point in having these in the main project file given that they are designed for maintainer/tester use.
Use defined(INTERNAL_TESTING) instead. This uncovered some bugs in reporting assertion messages before the message logging window was displayed -- which has now been fixed.
This function is not internal-only, so it needed to be moved out of the internal-only code.
Randalphwa
marked this pull request as draft
September 19, 2026 14:12
Guard the message-logger window, teardown, and project-import log clearing behind INTERNAL_TESTING, and make the MSG_* macros inline no-ops elsewhere, fixing Release link failures now that msg_logging.cpp is not compiled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all of the internal-only UI into it's own project file -- the internal generated .cmake file combines with a cmake/internal.cmake file to keep all of the internal UI and code together, so that it only gets compiled into the project when actually requested.
This PR also removes the hidden '"test_menu" command line option. Trying to maintain which testing code was under the menu, or under internal, or Debug-only builds was getting more and more complicated. I'm expecting to expand the testing functionality.