Skip to content

feat(api): support timeout_ms on remember and search #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moltar-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(api): support timeout_ms on remember and search #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/keyoku-server/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func NewHandlers(k *keyoku.Keyoku, hub *SSEHub) *Handlers {
type rememberRequest struct {
EntityID string `json:"entity_id"`
Content string `json:"content"`
TimeoutMs int `json:"timeout_ms,omitempty"`
SessionID string `json:"session_id,omitempty"`
AgentID string `json:"agent_id,omitempty"`
Source string `json:"source,omitempty"`
Expand All @@ -51,6 +52,7 @@ type rememberResponse struct {
type searchRequest struct {
EntityID string `json:"entity_id"`
Query string `json:"query"`
TimeoutMs int `json:"timeout_ms,omitempty"`
Limit int `json:"limit,omitempty"`
Mode string `json:"mode,omitempty"`
AgentID string `json:"agent_id,omitempty"`
Expand Down
32 changes: 30 additions & 2 deletions cmd/keyoku-server/handlers_memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package main

import (
"context"
"fmt"
"net/http"
"sort"
Expand All @@ -14,6 +15,19 @@ import (
"github.com/keyoku-ai/keyoku-engine/storage"
)

func requestTimeout(timeoutMs int) (time.Duration, bool) {
if timeoutMs <= 0 {
return 0, false
}
if timeoutMs < 1000 {
timeoutMs = 1000
}
if timeoutMs > 300000 {
timeoutMs = 300000
}
return time.Duration(timeoutMs) * time.Millisecond, true
}

// HandleRemember extracts and stores memories from content.
func (h *Handlers) HandleRemember(w http.ResponseWriter, r *http.Request) {
var req rememberRequest
Expand Down Expand Up @@ -66,7 +80,14 @@ func (h *Handlers) HandleRemember(w http.ResponseWriter, r *http.Request) {
opts = append(opts, keyoku.WithCreatedAt(t))
}

result, err := h.k.Remember(r.Context(), req.EntityID, req.Content, opts...)
ctx := r.Context()
if timeout, ok := requestTimeout(req.TimeoutMs); ok {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, timeout)
defer cancel()
}

result, err := h.k.Remember(ctx, req.EntityID, req.Content, opts...)
if err != nil {
writeInternalErrorWithContext(w, "remember", err)
return
Expand Down Expand Up @@ -115,7 +136,14 @@ func (h *Handlers) HandleSearch(w http.ResponseWriter, r *http.Request) {
opts = append(opts, keyoku.WithSearchAgentID(req.AgentID))
}

results, err := h.k.Search(r.Context(), req.EntityID, req.Query, opts...)
ctx := r.Context()
if timeout, ok := requestTimeout(req.TimeoutMs); ok {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, timeout)
defer cancel()
}

results, err := h.k.Search(ctx, req.EntityID, req.Query, opts...)
if err != nil {
writeInternalErrorWithContext(w, "search", err)
return
Expand Down
Loading