Skip to content

fix(server): surface partial results in list-all-entities #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyejcoleman merged 1 commit into from
Jun 18, 2026
Merged

fix(server): surface partial results in list-all-entities #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmd/keyoku-server/handlers_memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package main

import (
"fmt"
"log"
"net/http"
"sort"
"strings"
Expand Down Expand Up @@ -209,13 +210,21 @@ func (h *Handlers) HandleListMemories(w http.ResponseWriter, r *http.Request) {
return
}
var allMemories []memoryJSON
skipped := 0
for _, eid := range entities {
memories, err := h.k.List(r.Context(), eid, limit)
if err != nil {
// Don't fail the whole request for one bad entity — but don't hide
// it either: a silent skip makes a partial 200 look complete.
log.Printf("WARN: list memories for entity %q failed, skipping: %v", eid, err)
skipped++
continue
}
allMemories = append(allMemories, toMemoryJSONSlice(memories)...)
}
if skipped > 0 {
log.Printf("WARN: list-all-entities returned partial results: %d of %d entities skipped", skipped, len(entities))
}
// Sort by created_at descending, then cap to limit
sort.Slice(allMemories, func(i, j int) bool {
return allMemories[i].CreatedAt.After(allMemories[j].CreatedAt)
Expand Down
Loading