Complete removal of /api/staff/ and /api/users/ API implementations#16
Merged
Complete removal of /api/staff/ and /api/users/ API implementations#16
Conversation
…ions - Remove all staff-related API controllers (StaffApiController, UserApiController) - Delete staff service layer (StaffService, StaffRepository) - Remove staff entity and DTOs (StaffEntity, CreateStaffRequest, StaffResponse) - Update SaleEntity to remove staffId dependency - Remove staff table from database schema (V000__create_tables.sql) - Update all sale processing services to remove staff barcode handling - Remove staff management frontend (StaffsController, templates) - Clean up all test files and remove staff-related test cases - Update API specification (api.yaml) to remove staff/users endpoints - Fix all compilation errors and ktlint formatting issues Both /api/staff/ and /api/users/ APIs were duplicates using the same StaffService and are no longer needed. Sales processing now works without staff references. Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
…tests Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
…est timeouts Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
- 10桁バーコードフォーマットを実装（A + 種別コード(2桁) + ID(6桁) + A） - ITEM種別コード: 01 - 空欄時は自動生成 - フロントエンド入力を6桁のみに簡略化（A01___A形式で表示） - PDF出力ボタンを修復（CSS display:none ルールを削除） - PDFダウンロードをfetch + Blob方式に改善 - OpenAPI仕様書からStaff/Users API定義を削除
Contributor
🎨 Visual Regression Test Results❌ Visual regression tests failed Some pages have visual differences. Please review the artifacts: 📋 Actions to take:
📊 Test Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete removal of /api/staff/ and /api/users/ API implementations
Summary
This PR completely removes the
/api/staff/and/api/users/API implementations from KidsPOS-Server, including all related code, database schema updates, and frontend components. Both APIs were duplicates that used the same StaffService and are no longer needed.Key Changes:
staffIdfrom sale table andstafftable entirelyThe sales processing logic has been simplified to work without staff barcodes, and receipt printing no longer includes staff names.
Review & Testing Checklist for Human
Critical items to verify (5 items):
staffIdreferences won't cause issues (user confirmed no migrations needed)Notes
/api/staff/or/api/users/endpoints will need updates