feat: EventBusをKotlin Flows + SharedFlowに移行#27
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: EventBusをKotlin Flows + SharedFlowに移行#27devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- GreenRobot EventBusからKotlin Flows + SharedFlowベースの実装に置き換え - 既存のEventBusインターフェースを維持し、破壊的変更を回避 - @subscribeアノテーションとリフレクションベースの自動検出を実装 - Android 7互換性を維持 - 依存関係からeventbusライブラリを削除 - ProGuardルールを新しい実装に対応 変更内容: - EventBusImpl: SharedFlowとCoroutineScopeを使用した新実装 - Subscribe/ThreadModeアノテーション: 独自実装で互換性維持 - ViewModels: importを新しいアノテーションに更新 - build.gradle: eventbus依存関係を削除 - proguard-rules.pro: 新しいアノテーション用ルールに更新 Co-Authored-By: Atsumi3 <atsumi@mail.bizen.jp>
Author
|
Prompt hidden (unlisted session) |
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: EventBusをKotlin Flows + SharedFlowに移行
Summary
GreenRobot EventBusからKotlin Flows + SharedFlowベースの実装に完全移行しました。既存の
EventBusインターフェースを維持し、@Subscribeアノテーションの互換性を保つことで破壊的変更を回避しています。主な変更:
EventBusImpl: SharedFlowとCoroutineScopeを使用した新実装@Subscribe/ThreadModeアノテーション実装Review & Testing Checklist for Human
BarcodeEvent,SystemEvent)が正常に配信されることを実機で確認@Subscribeメソッドが正常に検出・実行されることを確認（特にItemListViewModel, MainViewModelの各ハンドラー）推奨テストプラン:
Notes
Link to Devin run: https://app.devin.ai/sessions/e8db403c6a7f489e98587b21afcb7330
Requested by: @Atsumi3