feat(kiloclaw): support Northflank tier resize#3115
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (13 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.5-20260423 · 1,220,687 tokens |
| targetTier, | ||
| deploymentPlan, | ||
| }); | ||
| await patchDeploymentService(config, providerState.projectId, providerState.serviceId, { |
There was a problem hiding this comment.
WARNING: Resize is persisted before the Northflank rollout is confirmed
resizeMachine() persists the new tier immediately after this patch resolves, but patchDeploymentService only confirms the update was accepted. If the deployment later fails, the DO still records the larger instanceType, machineSize, and volumeSizeGb, and the admin UI reports completion even though runtime hardware may not have changed. This path should wait for the deployment to complete (as startRuntime/restartRuntime do) before returning success or persisting tier state.
There was a problem hiding this comment.
I don’t think we should wait here. The persisted tier is the desired state after provider acceptance, its also consistent with the Fly resize path, which persists instanceType/machineSize before the restarted Fly machine proves it is running on the new CPU/RAM.
If Northflank accepts the patch and later fails rollout, that is runtime/provider health drift for inspect/reconcile to surface, not a reason to keep the desired tier old.
jeanduplessis
left a comment
There was a problem hiding this comment.
Looks good overall. I agree with the existing Northflank resize thread as a non-blocking improvement suggestion: waiting for rollout completion before marking the resize done would reduce provider/state drift when Northflank accepts a patch but the rollout later fails. I did not add a duplicate line comment because that thread already covers the point.
Summary
resizeRuntimehook so provider-specific resize semantics stay inside the provider layer while Fly and docker-local keep their existing behavior.Verification
deployed regular instance , upgraded to 4x8
Visual Changes
Reviewer Notes
instance_typeread cache.