fix: stop reasoning-only loops for GLM/minimax#111
fix: stop reasoning-only loops for GLM/minimax#111marius-kilocode wants to merge 2 commits intodevfrom
Conversation
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
|
|
Hi! Thank you for taking the time to contribute to this project—we really appreciate it. 🙏 We are currently working on re-platforming the core of our VS Code and JetBrains extensions to be based on our new Kilo CLI, with a complete rebuild based on OpenCode as our new foundation, and the moment has come to promote this repository to become the main repository. To do that, we moved the code from this repository to the kilocode repository. This unfortunately means we cannot merge this branch here anymore. Please add https://github.com/Kilo-Org/kilocode.git as a remote, and push your branch there and create a new PR in https://github.com/Kilo-Org/kilocode . We unfortunately cannot do this for you as then the PR would not be in your name anymore. If you need any help, feel free to ask on our Discord in #kilo-dev-contributors Sorry for the inconvenience and thank you for contributing to Kilo! |
Problem
Some models (reported with
z-ai/glm-4.7:freeandminimax/minimax-m2.1:free) can stream only reasoning (<think>/reasoning deltas) and finish the step withfinish: \"unknown\".SessionPrompt.loopkeeps looping onunknown, causing an infinite repetition.Original issue: Kilo-Org/kilocode#6333
Fix
MessageReasoningStuckError.SessionProcessor, track whether a step produced any non-reasoning output (text/tool parts).unknown), mark the message withMessageReasoningStuckErrorand stop the loop.Tests
bun run typecheckbun test(packages/opencode)Closes Kilo-Org/kilocode#6333