feat(cli): add roll-call command for batch-testing model connectivity#463
feat(cli): add roll-call command for batch-testing model connectivity#463cbrunnkvist wants to merge 1 commit intoKilo-Org:devfrom
Conversation
|
@cbrunnkvist is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
a8337fd to
adb9f5d
Compare
26183e0 to
21f6738
Compare
21f6738 to
edafafb
Compare
733b6c7 to
886c3bb
Compare
| .option("retries", { | ||
| type: "number", | ||
| default: 0, | ||
| describe: "Number of additional retries for each model call", |
There was a problem hiding this comment.
WARNING: The retries option is defined here but never used in the handler.
On line 129, the destructuring const { prompt, timeout, filter, parallel, output, verbose, quiet } = args omits retries, and no retry logic exists in processModel. Users passing --retries 3 would expect failed model calls to be retried, but the flag silently does nothing.
Either implement retry logic in processModel or remove this option to avoid misleading users.
| @@ -0,0 +1,298 @@ | |||
| import type { Argv } from "yargs" | |||
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change - new file marker.
Per AGENTS.md, new files outside of kilocode-named directories should have a // kilocode_change - new file comment at the top to help identify Kilo-specific additions during upstream merges. The test file has this marker but the source file does not.
| import type { Argv } from "yargs" | |
| // kilocode_change - new file | |
| import type { Argv } from "yargs" |
| import { UpgradeCommand } from "./cli/cmd/upgrade" | ||
| import { UninstallCommand } from "./cli/cmd/uninstall" | ||
| import { ModelsCommand } from "./cli/cmd/models" | ||
| import { RollCallCommand } from "./cli/cmd/roll-call" |
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change marker on this new import.
Per AGENTS.md, modifications to shared upstream files should be marked with kilocode_change comments so they can be easily identified during merges.
| import { RollCallCommand } from "./cli/cmd/roll-call" | |
| import { RollCallCommand } from "./cli/cmd/roll-call" // kilocode_change |
| .command(ServeCommand) | ||
| .command(WebCommand) | ||
| .command(ModelsCommand) | ||
| .command(RollCallCommand) |
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change marker on this new command registration.
| .command(RollCallCommand) | |
| .command(RollCallCommand) // kilocode_change |
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
|
|
Hi! Thank you for taking the time to contribute to this project—we really appreciate it. 🙏 We are currently working on re-platforming the core of our VS Code and JetBrains extensions to be based on our new Kilo CLI, with a complete rebuild based on OpenCode as our new foundation, and the moment has come to promote this repository to become the main repository. To do that, we moved the code from this repository to the kilocode repository. This unfortunately means we cannot merge this branch here anymore. Please add https://github.com/Kilo-Org/kilocode.git as a remote, and push your branch there and create a new PR in https://github.com/Kilo-Org/kilocode . We unfortunately cannot do this for you as then the PR would not be in your name anymore. If you need any help, feel free to ask on our Discord in #kilo-dev-contributors Sorry for the inconvenience and thank you for contributing to Kilo! |
Summary
This PR adds a new
roll-callsubcommand that allows users to batch-test multiple models for connectivity and latency. This helps users discover which provider/model pairs are available and working.Features
Technical Details
The implementation:
ProviderTransformoptions (maxOutputTokens,temperature,topP,topK,providerOptions)Testing
Tested with various model filters:
Demonstrating truncation, error handling, color coding:
Related Issue
Closes Kilo-Org/kilocode#6304