Skip to content

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented Dec 22, 2025

Part of #9271.

Before merging:

  • Fix sketch on negative planes

The main change here is that sketch blocks now accept any Plane for their on parameter and ensure that it's sent to the engine.

Secondary changes:

  • Plane was restructured so that it has an ObjectId if and only if it's been sent to the engine.
  • To fix the types of the frontend sketch API, the sketch block on argument is now required by the parser to be a variable or other identifier, like a tag. The plan is that we can relax this restriction later. But in the short-term, it makes it simpler to implement partial execution Partial execution of sketch block only #9434 because it guarantees that the argument will always be in memory, which mock execution has access to on subsequent runs.

@jtran jtran added the sketch-solve PRs changing sketch-solve functionality only. label Dec 22, 2025
@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
modeling-app Ready Ready Preview, Comment Jan 5, 2026 8:04pm

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #9454 will not alter performance

Comparing jtran/sketch-on-any-plane (f19a415) with main (8260030)1

Summary

✅ 152 untouched
⏩ 92 skipped2

Footnotes

  1. No successful run was found on main (2f5e683) during the generation of this report, so 8260030 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sketch-solve PRs changing sketch-solve functionality only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants