-
Notifications
You must be signed in to change notification settings - Fork 98
Sketch on any plane #9454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sketch on any plane #9454
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging #9454 will not alter performanceComparing Summary
Footnotes
|
80064f5 to
aadf346
Compare
aadf346 to
b17a38f
Compare
b17a38f to
2b5af8a
Compare
2b5af8a to
859413e
Compare
859413e to
28f9a07
Compare
28f9a07 to
b21bc0d
Compare
The plane Object ID in frontend tests is wrong.
Ignore it for now.
b21bc0d to
f19a415
Compare
Part of #9271.
Before merging:
The main change here is that sketch blocks now accept any
Planefor theironparameter and ensure that it's sent to the engine.Secondary changes:
Planewas restructured so that it has anObjectIdif and only if it's been sent to the engine.onargument is now required by the parser to be a variable or other identifier, like a tag. The plan is that we can relax this restriction later. But in the short-term, it makes it simpler to implement partial execution Partial execution of sketch block only #9434 because it guarantees that the argument will always be in memory, which mock execution has access to on subsequent runs.