#9182 Fix video resize bug on safari by applying object-fit: fill #9505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewvarga
changed the title
pierremtb
approved these changes
Jan 2, 2026
Contributor
pierremtb
left a comment
pierremtb
left a comment
There was a problem hiding this comment.
Tested in vercel and that fixes it. The stretch-on-resize looks weird but it's definitely an improvement since it doesn't break once the resize is done.
Contributor
Author
Thanks. I haven't really found a more elegant solution yet, so I'll merge this and we can replace it with something better if we find one. I don't feel like it's risky because its Safari specific and only improves the situation there. |
Contributor
|
100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9182 on safari.
It's pretty weird, but very easily reproducible on Safari and
object-fit: fillfixes it.https://hacks.mozilla.org/2015/02/exploring-object-fit/#:~:text=Overriding%20a%20video%E2%80%99s%20aspect%20ratio%20with%20object%2Dfit%3A%20fill
I only apply to Safari because it makes the video stretch in Chrome during the resize (it's correct when the resizing stops, but it looks a bit weird in the interim).
Doing a bit more investigation to see if there is an alternative solution to this..