Skip to content

Fix vpx encoder shutdown#45

Merged
jspanchu merged 1 commit into
masterfrom
fix-vpx-encoder-shutdown
Jul 3, 2026
Merged

Fix vpx encoder shutdown#45
jspanchu merged 1 commit into
masterfrom
fix-vpx-encoder-shutdown

Conversation

@jspanchu

@jspanchu jspanchu commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Bumps vtk-streaming to 0.3.4
  • Removes unnecessary call to encoder reset upon size change, the encoder automatically detects size changes and rebuilds what is necessary.

@jspanchu jspanchu force-pushed the fix-vpx-encoder-shutdown branch 2 times, most recently from 2f8d459 to de991c4 Compare July 3, 2026 15:37
jourdain
jourdain reviewed Jul 3, 2026
View reviewed changes
Comment thread README.rst Outdated
@jspanchu
fix(video_rca): bump vtk-streaming to 0.3.4 for vpx encoder fix
f1ab553 
- just call set_size if window size is different from last encode
  isntead of recreating encoder and frame from sratch
@jspanchu jspanchu force-pushed the fix-vpx-encoder-shutdown branch from de991c4 to f1ab553 Compare July 3, 2026 15:38
@jourdain jourdain self-requested a review July 3, 2026 15:39
@jspanchu jspanchu merged commit 6a7574e into master Jul 3, 2026
7 checks passed
@jspanchu jspanchu deleted the fix-vpx-encoder-shutdown branch July 11, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jourdain jourdain jourdain approved these changes
@Thibault-Pelletier Thibault-Pelletier Awaiting requested review from Thibault-Pelletier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jspanchu @jourdain