feat: add the ability to pass additional data arguments LocalView.update()#71
feat: add the ability to pass additional data arguments LocalView.update()#71ansbbrooks wants to merge 1 commit into
LocalView.update()#71Conversation
ansbbrooks
changed the title
LocalView.update()LocalView.update()
| return self._update_throttle | ||
|
|
||
| def update(self, push_camera=False): | ||
| def update(self, push_camera=False, *args: Any): |
There was a problem hiding this comment.
I would rather use kwargs and just send it as a single object to the method call.
There was a problem hiding this comment.
Thanks but looking at the JS side, we have an issue.
https://github.com/Kitware/trame-vtklocal/blob/master/vue-components/src/components/VtkLocal.js#L270
I will need to do that change with the new version of vtk-wasm. But I'll keep that in mind once I do the code change.
There was a problem hiding this comment.
I just pushed a commit that should fix this.
|
I'm ok with those changes for now to solve your needs, but ideally, I want to provide a better solution. But I'll tackle it with the latest version of vtk-wasm. You have to use semantic release for your commit and fix the Any annotation. |
ansbbrooks
force-pushed
the
local-view-update-args-1
branch
from
c8d7cd9 to
960a8b9
Compare
…LocalView.update() method. Pass one object instead of unwrapping it into multiple arguments. Ensure the "bindCanvas" JS portion still works correctly with the optional data payload. fixed "any" annotation
ansbbrooks
force-pushed
the
local-view-update-args-1
branch
from
960a8b9 to
b8f903f
Compare
Done, let me know if that looks good. |
|
I'm currently in the process of updating Should I squeeze you change before, or are you ok to wait? |
I can wait, no problem. |
|
Closing as #72 includes the needed change. |
2 participants
Occasionally we need to send additional arbitrary data to the frontend when we make a call to
LocalView.update()on the server. This PR adds the ability to pass arguments to the call toServer.js_call()thatLocalView.update()makes internally.