fix: pass Chromium sandbox flags to the HTML render step - #73
Merged
Conversation
md-to-pdf --as-html still launches Puppeteer/Chromium under the hood, but this step was missing the --no-sandbox/--disable-setuid-sandbox launch options already used by the PDF step. On GitHub Actions runners (no usable user namespace sandbox), Chromium crashed with 'No usable sandbox', breaking the CI run on push to main.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Section modified: CI/CD —
.github/workflows/generate-pdf.yml(Render full HTML for Word conversion step)Motivation: The last push to
main(after merging PR #70) broke theGenerate PDF from READMEworkflow in production. The new "Render full HTML for Word conversion" step callsmd-to-pdf --as-html, which still launches Puppeteer/Chromium under the hood, but was missing the--no-sandbox --disable-setuid-sandboxlaunch options already used by the "Generate PDF" step. On GitHub Actions runners (no usable user-namespace sandbox), Chromium crashed with "No usable sandbox", failing the run right after PR #72 merged develop into main.Type of Change
Checklist Before Requesting Review
develop(notmain)feature/*orbugfix/*feat:,fix:,docs:, etc.)CHANGELOG.mdhas been updated with the change madeassets/subfolder — N/A.pdf,.docx,.html)Screenshots or Evidence (optional)
Failing run on
mainafter PR #72: workflowGenerate PDF from README, run29069830937— ChromiumFATAL: No usable sandbox!. Verified locally thatmd-to-pdf --as-html --basedir . --launch-options '{"args":["--no-sandbox","--disable-setuid-sandbox"]}'runs cleanly with the flag added.Suggested Reviewers
@jhosepmyr