feat(custom-scraper): add Skip button for sub-scrapers with no results#1979
Open
Arny80Hexa wants to merge 1 commit intoKomet:masterfrom
Open
feat(custom-scraper): add Skip button for sub-scrapers with no results#1979Arny80Hexa wants to merge 1 commit intoKomet:masterfrom
Arny80Hexa wants to merge 1 commit intoKomet:masterfrom
Conversation
bugwelle
reviewed
Mar 24, 2026
Collaborator
bugwelle
left a comment
bugwelle
left a comment
There was a problem hiding this comment.
Hi!
Thank you for this PR.
See one inline comment regarding method names. Besides that: Thanks! Tested locally and works. :)
| connect(ui->movieSearchWidget, | ||
| &MovieSearchWidget::sigCustomScrapingChanged, | ||
| this, | ||
| &MovieSearch::onCustomScrapingChanged); |
Collaborator
There was a problem hiding this comment.
I believe the method name is misleading. Isn't it rather a onScraperChanged(bool isCustomerScraper)?
When using the Custom Movie Scraper, each sub-scraper requires the user to select a search result before proceeding. If a sub-scraper returns no results (e.g. the movie doesn't exist on VideoBuster), the user was stuck with no way to continue. Add a Skip button that appears whenever the Custom Movie Scraper is active. It allows skipping any scraper — including the title scraper — and advancing to the next one. The backend already handles missing scrapers gracefully (CustomMovieScraper::loadMovie silently skips any scraper not in the customScraperIds map). Fixes Komet#1978 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Arny80Hexa
force-pushed
the
feat/custom-scraper-skip-button
branch
from
88f5b50 to
ce4796f
Compare
Contributor
Author
|
Renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomMovieScraper::loadMovie()silently skips any scraper not in thecustomScraperIdsmap) — this change only adds the missing UI capabilityFixes #1978
Test plan
Developed with AI assistance (Claude Code / Opus 4.6).