Skip to content

fix(cli): default all release builds to staging so the default install serves staging during testing #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkkhq merged 1 commit into from
Jul 25, 2026
Merged

fix(cli): default all release builds to staging so the default install serves staging during testing #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ jobs:
env:
CLI_VERSION: ${{ needs.resolve-release.outputs.cli_version }}
PRODUCTION_FIRST_PARTY_DEVICE_CLIENT_ID: ${{ vars.VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION }}
# ponytail: staging client ID consumed only by the main/nightly path during the testing phase; drop this line to end the staging test phase
# ponytail: every release path builds against staging during the testing phase, so all builds consume the staging client ID; drop this line and restore the production blocks in resolve-cli-build-env.sh before GA
STAGING_FIRST_PARTY_DEVICE_CLIENT_ID: ${{ vars.VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_STAGING }}
run: scripts/ci/resolve-cli-build-env.sh

Expand Down
25 changes: 18 additions & 7 deletions scripts/ci/resolve-cli-build-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ if [ -z "${GITHUB_ENV:-}" ]; then
exit 1
fi

CLI_DEFAULT_API_URL="https://api.volcano.dev"
CLI_DEFAULT_WEB_URL="https://volcano.dev"
# ponytail: staging default for the whole testing phase so every release path
# (including stable tags -> `latest`/npm/brew) builds against staging; restore
# these two lines and each per-case block below before GA
# CLI_DEFAULT_API_URL="https://api.volcano.dev"
# CLI_DEFAULT_WEB_URL="https://volcano.dev"
CLI_DEFAULT_API_URL="https://api.staging.volcano.dev"
CLI_DEFAULT_WEB_URL="https://staging.volcano.dev"
CLI_FIRST_PARTY_DEVICE_CLIENT_ID=""

case "$REF" in
Expand All @@ -29,14 +34,20 @@ case "$REF" in
echo "Release tags must use stable SemVer form vMAJOR.MINOR.PATCH or nightly form v0.0.N-nightly.YYYYMMDD.NUMBER."
exit 1
fi
CLI_DEFAULT_API_URL="https://api.volcano.dev"
CLI_DEFAULT_WEB_URL="https://volcano.dev"
CLI_FIRST_PARTY_DEVICE_CLIENT_ID="${PRODUCTION_FIRST_PARTY_DEVICE_CLIENT_ID:-${VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION:-}}"
REQUIRED_DEVICE_CLIENT_ID_VAR="VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION"
# ponytail: stable tags build against staging during the testing phase so
# `latest`/npm default to staging; restore these four lines before GA
# CLI_DEFAULT_API_URL="https://api.volcano.dev"
# CLI_DEFAULT_WEB_URL="https://volcano.dev"
# CLI_FIRST_PARTY_DEVICE_CLIENT_ID="${PRODUCTION_FIRST_PARTY_DEVICE_CLIENT_ID:-${VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION:-}}"
# REQUIRED_DEVICE_CLIENT_ID_VAR="VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION"
CLI_DEFAULT_API_URL="https://api.staging.volcano.dev"
CLI_DEFAULT_WEB_URL="https://staging.volcano.dev"
CLI_FIRST_PARTY_DEVICE_CLIENT_ID="${STAGING_FIRST_PARTY_DEVICE_CLIENT_ID:-${VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_STAGING:-}}"
REQUIRED_DEVICE_CLIENT_ID_VAR="VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_STAGING"
CLI_VERSION="$REF_NAME"
;;
refs/heads/main)
# ponytail: staging default scoped to main/nightly (prerelease, never latest/npm) for the testing phase; restore these four lines to end the staging test phase
# ponytail: staging default for the testing phase (nightly); restore these four lines before GA
# CLI_DEFAULT_API_URL="https://api.volcano.dev"
# CLI_DEFAULT_WEB_URL="https://volcano.dev"
# CLI_FIRST_PARTY_DEVICE_CLIENT_ID="${PRODUCTION_FIRST_PARTY_DEVICE_CLIENT_ID:-${VOLCANO_FIRST_PARTY_DEVICE_CLIENT_ID_PRODUCTION:-}}"
Expand Down