Skip to content

Bump version, prepare packages#38

Open
ouziel-slama wants to merge 11 commits intomainfrom
packages
Open

Bump version, prepare packages#38
ouziel-slama wants to merge 11 commits intomainfrom
packages

Conversation

@ouziel-slama
Copy link
Copy Markdown
Contributor

@ouziel-slama ouziel-slama commented Apr 10, 2026

Note

Medium Risk
Medium risk because it changes the on-the-wire hex encoding for field elements (breaking persisted metadata/roots) and updates golden regression vectors; also adds automated publishing which could mis-publish if misconfigured.

Overview
Prepares the 0.2.0 release and changes field element hex serialization to canonical PrimeField::to_repr() byte order (little-endian). This updates field_to_hex/field_from_hex in kontor-crypto-core, adjusts Poseidon and prepare_file golden/regression expectations, and aligns the WASM/JS surface (worker Merkle path hex encoding and WASM descriptor root checks) to the same byte order.

Adds a GitHub Actions release.yml workflow to publish Rust crates (with a crates.io indexing wait) and then build/publish the npm package, and tweaks CI/WASM/formal workflows to use ubuntu-latest/ubuntu-latest-m runners. Versions are bumped to 0.2.0 across Rust crates and the npm package is renamed to @kontor/kontor-crypto (0.2.0-alpha), with updated crate metadata (license/repo fields) and a new CHANGELOG.md documenting the breaking change.

Reviewed by Cursor Bugbot for commit 6d6e9bf. Bugbot is set up for automated code reviews on this repo. Configure here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 10, 2026

Merging this PR will not alter performance

✅ 13 untouched benchmarks
⏩ 13 skipped benchmarks1


Comparing packages (19ad4bf) with main (e7e762e)

Open in CodSpeed

Footnotes

  1. 13 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread .github/workflows/formal-picus.yml
Comment thread .github/workflows/release.yml Outdated
Comment thread packages/kontor-crypto/package-lock.json
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5e3dd11. Configure here.

Comment thread .github/workflows/release.yml
Ouziel and others added 3 commits April 15, 2026 18:43
BREAKING: field_to_hex / field_from_hex (Rust + JS) now produce
canonical PrimeField::to_repr() little-endian hex instead of
big-endian. Aligns with Kontor indexer bytes_to_field_element
(from_repr expects LE), fixes ~75% silent failure rate on
create-agreement WIT calls. Golden values regenerated.
Fix endianness in field_to_hex / field_from_hex (LE canonical)
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Unable to generate the performance report

There was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants