Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e3dd11. Configure here.
BREAKING: field_to_hex / field_from_hex (Rust + JS) now produce canonical PrimeField::to_repr() little-endian hex instead of big-endian. Aligns with Kontor indexer bytes_to_field_element (from_repr expects LE), fixes ~75% silent failure rate on create-agreement WIT calls. Golden values regenerated.
Fix endianness in field_to_hex / field_from_hex (LE canonical)
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |

Note
Medium Risk
Medium risk because it changes the on-the-wire hex encoding for field elements (breaking persisted metadata/roots) and updates golden regression vectors; also adds automated publishing which could mis-publish if misconfigured.
Overview
Prepares the
0.2.0release and changes field element hex serialization to canonicalPrimeField::to_repr()byte order (little-endian). This updatesfield_to_hex/field_from_hexinkontor-crypto-core, adjusts Poseidon andprepare_filegolden/regression expectations, and aligns the WASM/JS surface (worker Merkle path hex encoding and WASM descriptor root checks) to the same byte order.Adds a GitHub Actions
release.ymlworkflow to publish Rust crates (with a crates.io indexing wait) and then build/publish the npm package, and tweaks CI/WASM/formal workflows to useubuntu-latest/ubuntu-latest-mrunners. Versions are bumped to0.2.0across Rust crates and the npm package is renamed to@kontor/kontor-crypto(0.2.0-alpha), with updated crate metadata (license/repo fields) and a newCHANGELOG.mddocumenting the breaking change.Reviewed by Cursor Bugbot for commit 6d6e9bf. Bugbot is set up for automated code reviews on this repo. Configure here.