fix(timeout): increasing port search timeout - #6
Open
CarolinePascal wants to merge 1 commit into
Open
Conversation
…time to pick the serial port to be opened
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there !
Here's a small PR increasing the timeout value of
port_search_timer_to 5 seconds instead of 0.5 seconds.In the current version, the 0.5 seconds timeout is almost instantaneously reached when selecting a port in the drop-down list. As a result, the selected port keeps reseting to its default value
debug-console, and makes it almost impossible to open another port than the default one.In the new version, the 5 seconds timeout is quite enough to select the desired port and open it :)
Thanks for providing such a nice tool for Unix users to debug Feetech servos !
Best,
Caroline.