Skip to content

Port CameraInfo Display to ROS 2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agonzat wants to merge 9 commits into
base: feat/ros2
Choose a base branch
from
Open

Port CameraInfo Display to ROS 2 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c05363c
Fix deprecation warning
agonzat Feb 18, 2024
3da60f1
Port CameraInfo display to ROS 2
agonzat Feb 18, 2024
7d9900e
Add author tag to package.xml
agonzat Feb 18, 2024
febc310
Reduce verbosity
agonzat Feb 18, 2024
afb5297
Mark CameraInfo availability in README
agonzat Feb 19, 2024
15bced1
Apply ament_clang_format to source
agonzat Feb 19, 2024
7efb2ce
Add copyright
agonzat Feb 19, 2024
ba7c31f
Also set the alpha for the bottom plane
agonzat Feb 19, 2024
68b65c8
jazzy compatibility minimal changes
Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ See [read the docs](http://jsk-visualization.readthedocs.org/en/latest/).
# 開発環境
- Ubuntu 20.04(ROS2 Foxy)
- Ubuntu 20.04(ROS2 Galactic)
- Ubuntu 22.04(ROS2 Humble) - Compilation Only

# 実装状況
## jsk_rviz_plugins
Expand Down Expand Up @@ -47,7 +48,7 @@ See [read the docs](http://jsk-visualization.readthedocs.org/en/latest/).
| TargetVisualizer | ✅ | ✅ | |
| Diagnostics | ✅ | ✅ | |
| LinearGauge | ✅ | ✅ | ✅ | |
| CameraInfo | | | |
| CameraInfo | ✅ | ✅ | |
| PoseArray | | | | (default pluginに実装済み?) |
| OverlayCamera | | | | (Panelを含む? )|
| PeoplePositionMeasuermentArray | | | | (msg未実装) |
Expand Down
15 changes: 8 additions & 7 deletions jsk_rviz_plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ find_package(geometry_msgs REQUIRED)
find_package(nav_msgs REQUIRED)

find_package(laser_geometry REQUIRED)
find_package(image_geometry REQUIRED)
find_package(map_msgs REQUIRED)
find_package(pluginlib REQUIRED)
find_package(resource_retriever REQUIRED)
Expand Down Expand Up @@ -107,17 +108,22 @@ add_library(jsk_rviz_plugins SHARED
src/close_all_tool.cpp
src/open_all_tool.cpp
src/screenshot_listener_tool.cpp
src/overlay_picker_tool.cpp)
src/overlay_picker_tool.cpp

### ViewController
# src/view_controller/tablet_view_controller.cpp )

### Properties
src/image_transport_hints_property.cpp

)
# Link ament packages
ament_target_dependencies(jsk_rviz_plugins
rclcpp
rviz_common
cv_bridge
image_transport
image_geometry
std_msgs
geometry_msgs
nav_msgs
Expand All @@ -137,12 +143,6 @@ ament_target_dependencies(jsk_rviz_plugins
# $<INSTALL_INTERFACE:include>
# )

if (NOT WIN32)
ament_environment_hooks(
"${ament_cmake_package_templates_ENVIRONMENT_HOOK_LIBRARY_PATH}"
)
endif()

# Link non ament packages
target_link_libraries(jsk_rviz_plugins Qt5::Widgets)

Expand All @@ -162,6 +162,7 @@ ament_export_dependencies(
image_transport
geometry_msgs
laser_geometry
image_geometry
map_msgs
nav_msgs
rclcpp
Expand Down
2 changes: 2 additions & 0 deletions jsk_rviz_plugins/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<author email="youhei@jsk.t.u-tokyo.ac.jp">Yohei Kakiuchi</author>
<author email="s-fujii@jsk.t.u-tokyo.ac.jp">Shohei Fujii</author>
<author email="ueda@jsk.t.u-tokyo.ac.jp">Ryohei Ueda</author>
<author email="ander.gonzalez@ikerlan.es">Ander Gonzalez</author> <!-- CameraInfo Display -->

<buildtool_depend>ament_cmake</buildtool_depend>

Expand All @@ -34,6 +35,7 @@
<depend>geometry_msgs</depend>
<!-- <depend>interactive_markers</depend> -->
<depend>laser_geometry</depend>
<depend>image_geometry</depend>
<depend>nav_msgs</depend>
<depend>map_msgs</depend>
<depend>pluginlib</depend>
Expand Down
4 changes: 2 additions & 2 deletions jsk_rviz_plugins/plugins_description.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@
</class>


<!-- <class name="jsk_rviz_plugin/CameraInfo"
<class name="jsk_rviz_plugin/CameraInfo"
type="jsk_rviz_plugins::CameraInfoDisplay"
base_class_type="rviz_common::Display">
<description>
visualize sensor_msgs/CameraInfo
</description>
</class> -->
</class>

<!-- <class name="jsk_rviz_plugin/PeoplePositionMeasurementArray"
type="jsk_rviz_plugins::PeoplePositionMeasurementArrayDisplay"
Expand Down
Loading
Loading