refactor: simplify container_exec, fix set -e bug and grep-c noise#1
Merged
refactor: simplify container_exec, fix set -e bug and grep-c noise#1
Conversation
- Merge container_exec_i into container_exec (-i as optional first arg) - cleanup() now uses container_exec instead of duplicated platform branch - Fix set -e bug in get_package_requirements: standalone container_exec call made the else error branch unreachable; moved into if condition - Fix docker inspect | grep -q true: replace with exact == "true" compare - Fix grep -c || echo "0" double-output; remove redundant tr -d cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container_exec_iintocontainer_exec— pass-ias optional first arg; removes duplicate functioncleanup()usescontainer_execinstead of hardcodeddocker exec/kubectl execbranchingset -ebug inget_package_requirements: standalonecontainer_exec bash -c "..."made theelseerror branch unreachable — moved intoifconditiondocker inspect | grep -q true→ exact== "true"comparisongrep -c || echo "0"double-output artifact; remove 4-linetr -dpost-processing block