[GeoMechanicsApplication] Move all non-template code to .cpp files and make sure any .h file does not contain any implementations (elements) #14055

markelov208 · 2025-12-09T23:27:20Z

📝 Description
A brief description of the PR.

Actions have been done for files in custom_elements folder

moved constructors and functions from header files to cpp files,
renamed U_Pw_element.h and integration_coefficients.h into hpp because they hold template functions and lamdas.
renamed hpp to h: U_Pw_base_element, U_Pw_small_strain_FIC_element, U_Pw_small_strain_element, U_Pw_small_strain_interface_element, U_Pw_updated_lagragian_FIC_element, U_Pw_updated_lagragian_element, geo_cr_beam_element_linear_2D2N, small_strain_U_Pw_diff_order_element,
steady_state_Pw_element, transient_Pw_element, and updated_lagragianU_Pw_diff_order_element

…-cpp-elements # Conflicts: # applications/GeoMechanicsApplication/test_setup_utilities/element_setup_utilities.cpp

…-cpp-elements

rfaasse

Thanks for the effort on the element! I mainly have comments about includes that can now be (re)moved from some headers and I think for the stress_state_policy.h header, we could still move some functions to the cpp.

rfaasse · 2025-12-23T07:51:31Z

applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h

 #include "custom_utilities/transport_equation_utilities.hpp"
 #include "custom_utilities/variables_utilities.hpp"
 #include "geo_mechanics_application_variables.h"
 #include "includes/cfd_variables.h"


These includes can probably be moved to the source file

rfaasse · 2025-12-23T07:58:37Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    Matrix CalculateNContainer()
+    {
+        return GetGeometry().ShapeFunctionsValues(GetIntegrationMethod());
+    }


This one can be moved to the cpp file

rfaasse · 2025-12-23T07:58:47Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    Vector CalculateIntegrationCoefficients()
+    {
+        GetGeometry().DeterminantOfJacobian(mDetJCcontainer, this->GetIntegrationMethod());
+        return mIntegrationCoefficientsCalculator.Run<Vector>(
+            GetGeometry().IntegrationPoints(GetIntegrationMethod()), mDetJCcontainer, this);
+    }


This one can be moved to the cpp file

rfaasse · 2025-12-23T07:58:53Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    std::vector<double> CalculateFluidPressure()
+    {
+        return GeoTransportEquationUtilities::CalculateFluidPressures(
+            mNContainer, VariablesUtilities::GetNodalValuesOf<TNumNodes>(WATER_PRESSURE, this->GetGeometry()));
+    }


This one can be moved to the cpp file

rfaasse · 2025-12-23T07:59:05Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    [[nodiscard]] DofsVectorType GetDofs() const
+    {
+        return Geo::DofUtilities::ExtractDofsFromNodes(GetGeometry(), WATER_PRESSURE);
+    }


This one can be moved to the cpp file

rfaasse · 2025-12-23T08:18:36Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_interface_element.h

-#include "custom_elements/U_Pw_base_element.hpp"
+#include "custom_elements/U_Pw_base_element.h"
 #include "custom_utilities/interface_element_utilities.h"
 #include "geo_mechanics_application_variables.h"


moved to cpp

rfaasse · 2025-12-23T08:19:57Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


These two includes are no longer used (maybe in the cpp)

stress_strain_utilities is removed and geo.. moved to cpp

rfaasse · 2025-12-23T08:21:21Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_FIC_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


the same ;)

rfaasse · 2025-12-23T08:22:14Z

...cations/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.h


    /// Default Constructor
-    UpdatedLagrangianUPwDiffOrderElement() : SmallStrainUPwDiffOrderElement() {}
+    UpdatedLagrangianUPwDiffOrderElement();


I think this could be just an =default in the header:

Suggested change

UpdatedLagrangianUPwDiffOrderElement();

UpdatedLagrangianUPwDiffOrderElement() = default;

rfaasse · 2025-12-23T08:23:04Z

...cations/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


These two seem to be unused (maybe also element_utilities?)

stress_strain_utilities is removed and geo.. moved to cpp.

markelov208

Hi Richard, many thanks for the review. I moved more includes to cpp, as a result some test files have been updated.

markelov208 · 2025-12-23T10:18:43Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+
+    typename FluidBodyFlowCalculator<TNumNodes>::InputProvider CreateFluidBodyFlowInputProvider();
+
+    auto MakePropertiesGetter()


It is possible to move them to cpp. They shall be converted to real functions that is a lot of work and may slow down Kratos.

markelov208 · 2025-12-23T10:19:03Z

applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h

 #include "custom_utilities/transport_equation_utilities.hpp"
 #include "custom_utilities/variables_utilities.hpp"
 #include "geo_mechanics_application_variables.h"
 #include "includes/cfd_variables.h"


markelov208 · 2025-12-23T10:19:38Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    Matrix CalculateNContainer()
+    {
+        return GetGeometry().ShapeFunctionsValues(GetIntegrationMethod());
+    }


markelov208 · 2025-12-23T10:19:48Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    Vector CalculateIntegrationCoefficients()
+    {
+        GetGeometry().DeterminantOfJacobian(mDetJCcontainer, this->GetIntegrationMethod());
+        return mIntegrationCoefficientsCalculator.Run<Vector>(
+            GetGeometry().IntegrationPoints(GetIntegrationMethod()), mDetJCcontainer, this);
+    }


markelov208 · 2025-12-23T10:20:08Z

applications/GeoMechanicsApplication/custom_elements/Pw_element.hpp

+    std::vector<double> CalculateFluidPressure()
+    {
+        return GeoTransportEquationUtilities::CalculateFluidPressures(
+            mNContainer, VariablesUtilities::GetNodalValuesOf<TNumNodes>(WATER_PRESSURE, this->GetGeometry()));
+    }


markelov208 · 2025-12-23T10:25:06Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_interface_element.h

-#include "custom_elements/U_Pw_base_element.hpp"
+#include "custom_elements/U_Pw_base_element.h"
 #include "custom_utilities/interface_element_utilities.h"
 #include "geo_mechanics_application_variables.h"


moved to cpp

markelov208 · 2025-12-23T10:25:58Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


stress_strain_utilities is removed and geo.. moved to cpp

markelov208 · 2025-12-23T10:27:00Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_FIC_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


the same ;)

markelov208 · 2025-12-23T10:27:23Z

...cations/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.h


    /// Default Constructor
-    UpdatedLagrangianUPwDiffOrderElement() : SmallStrainUPwDiffOrderElement() {}
+    UpdatedLagrangianUPwDiffOrderElement();


markelov208 · 2025-12-23T10:28:31Z

...cations/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.h

 #include "custom_utilities/stress_strain_utilities.h"
 #include "geo_mechanics_application_variables.h"


stress_strain_utilities is removed and geo.. moved to cpp.

rfaasse

Thanks for processing the review comments, to me this looks ready to go!

markelov208 · 2025-12-23T13:48:43Z

Hi @avdg81 , Richard made a very thorough review. If you would like to take a look, please could you let me know? Thank you.

processed elements

66a7b60

markelov208 self-assigned this Dec 9, 2025

markelov208 requested a review from a team as a code owner December 9, 2025 23:27

markelov208 added 5 commits December 11, 2025 09:36

fixed 7 code smells

7116957

second part

1f82dc9

third part

5359752

Merge branch 'master' into geo/14046-move-non-template-code-from-h-to…

b1165af

…-cpp-elements # Conflicts: # applications/GeoMechanicsApplication/test_setup_utilities/element_setup_utilities.cpp

fourth part

ff96db9

markelov208 requested review from avdg81 and rfaasse December 17, 2025 07:55

markelov208 added 3 commits December 19, 2025 14:42

Merge branch 'master' into geo/14046-move-non-template-code-from-h-to…

ae894ce

…-cpp-elements

added using namespace std::string_literals;

070fd81

clang-format

af5aa2a

WPK4FEM linked an issue Dec 22, 2025 that may be closed by this pull request

[GeoMechanicsApplication] Move all non-template code to .cpp files and make sure any .h file does not contain any implementations #14046

Closed

rfaasse reviewed Dec 23, 2025

View reviewed changes

markelov208 added 2 commits December 23, 2025 11:10

response to the review comments

8186d17

removed to includes with stress_strain_utilities

b5b4fd6

markelov208 commented Dec 23, 2025

View reviewed changes

rfaasse approved these changes Dec 23, 2025

View reviewed changes

		#include "custom_utilities/stress_strain_utilities.h"
		#include "geo_mechanics_application_variables.h"

	UpdatedLagrangianUPwDiffOrderElement();
	UpdatedLagrangianUPwDiffOrderElement() = default;


		typename FluidBodyFlowCalculator<TNumNodes>::InputProvider CreateFluidBodyFlowInputProvider();

		auto MakePropertiesGetter()

[GeoMechanicsApplication] Move all non-template code to .cpp files and make sure any .h file does not contain any implementations (elements) #14055

Are you sure you want to change the base?

[GeoMechanicsApplication] Move all non-template code to .cpp files and make sure any .h file does not contain any implementations (elements) #14055

Conversation

markelov208 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfaasse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markelov208 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rfaasse left a comment

Choose a reason for hiding this comment

Uh oh!

markelov208 commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

markelov208 commented Dec 9, 2025 •

edited

Loading