Skip to content

Conversation

@mnabideltares
Copy link
Contributor

📝 Description
In order to start with implementation of the compression cap, it is more efficient to document the mathematical formulations, algorithms and the way how to implement. This issue focuses on documentation of the compression cap.

At the moment, the formulation is based on p and q. Later we need to find a way to find the intersection between the yield surfaces.

🆕 Changelog

  • Added documentation in the form of markdown

Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohamed,
This is well on its way and in some places already more than asked.
Please find my remarks.
Regards, Wijtze Pieter

Comment on lines 50 to 59

```math
p_c = p_{c0} + H \epsilon^p
```
where:
- $`p_{c0}`$ = the initial cap position
- $`H`$ = the hardening modulus
- $`\epsilon^p`$ = the plastic volumetric strain

This produces compaction hardening: as the material densifies, it supports higher compressive stresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave out hardening until the moment that we really address it.

@mnabideltares mnabideltares requested a review from WPK4FEM January 6, 2026 08:02
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohamed,
Thank you for this documentation, I think its very close and I hope that taking up the remarks is now a small effort. Please proceed with the implementation of the cap yield surface and the derivatives of the flow function like was done when MC was started ( just F, dG/d sigma and unit tests for that as stand alone thing )
Regards, Wijtze Pieter


### Mohr–Coulomb yield surface

In the $`(\sigma, \tau)`$ stress space, the Mohr-Coulmb yiel surface is expressed as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the $`(\sigma, \tau)`$ stress space, the Mohr-Coulmb yiel surface is expressed as:
In the $`(\sigma, \tau)`$ stress space, the Mohr-Coulomb yield surface is expressed as:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a missing "d"

Comment on lines 66 to 70
Here, we need to convert the compression cap yield surface from $(p, q)$ coordinates to $(\sigma, \tau)$ coordinates. The conversion is to be followed ...

### Compression cap in $(\siga, \tau)$ coordinates
...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be left out for the time being, until we solved that challenge.

Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohamed,
Thank you for the modifications, 1 more spelling mistake found and 2 small remarks. With that it should be good to go.
Wijtze Pieter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Add documentation for compression cap for material models

3 participants