fix weird fullscreen window border bug - #667
Open
Goldofleaves wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the weird bug with borders as shown in:
This happens when you call love.window.setFullScreen(false) when you bootup on fullscreen mode, which is because love.windows.setFullScreen(false) falls back to the original window size before it was initially fullscreened. In the case of bootup, it is exactly the values used in love.conf since the initial Kristal.resetWindow call in love.load handles both fullscreening and editing the window size (which doesnt do anything in this case, since it is also fullscreening).
This pr removes the Kristal.resetWindow call in love.load and edits it to resize the window first (for love.window.setFullScreen to have a correct fallback value), then fullscreen the window.