Skip to content

feat(cli): add --timeout flag to demo command#292

Open
manikantavarma2889 wants to merge 9 commits into
KryptosAI:mainfrom
manikantavarma2889:feat/add-timeout-flag-demo
Open

feat(cli): add --timeout flag to demo command#292
manikantavarma2889 wants to merge 9 commits into
KryptosAI:mainfrom
manikantavarma2889:feat/add-timeout-flag-demo

Conversation

@manikantavarma2889

Copy link
Copy Markdown

Summary

  • Added the --timeout <ms> option to the demo command to support configurable timeouts for built-in or discovered MCP servers.
  • Passes timeoutMs to runTarget() via the target config, defaulting to 15000ms when the flag is omitted.
  • Invalid non-number values throw a clear validation error.

Code of Conduct

By submitting this pull request, you agree to follow the project's Contributor Covenant Code of Conduct.

Validation

  • npm run lint
  • npm run typecheck
  • npm test (Verified default/custom timeout and invalid value validation in tests/demo-command.test.ts)
  • npm run smoke

Artifact Impact

  • No artifact schema changes.
  • No changes to the Markdown report formatting.

@manikantavarma2889

Copy link
Copy Markdown
Author

The CI linter step is currently failing because the workflow uses pull_request_target, which checks out and installs the base main branch's incompatible typescript@7.0.2 dependency.

The changes in this PR include a downgrade to typescript@5.9.2 and ESLint configuration updates, which resolve the linter crash. All tests and lint checks pass cleanly when run on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant