Backport patch-safe fixes for v0.25.2 - #339
Conversation
Move bundle validation to run after bundle-custom-modifications so the final bundle (with OpenShift version labels, Quay expiry, and optional digest-specific changes) is validated once, regardless of USE_IMAGE_DIGESTS setting. Signed-off-by: Michael Nairn <mnairn@redhat.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: Guilherme Cassolato <guicassolato@gmail.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: Guilherme Cassolato <guicassolato@gmail.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: Guilherme Cassolato <guicassolato@gmail.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: averevki <sandyverevkin@gmail.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: averevki <sandyverevkin@gmail.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
Signed-off-by: Thomas Maas <thomas@webtypes.com>
…-directive The set-replaces-directive target fetches the latest release name to build the OLM replaces directive. When a release has an empty name field (e.g. created without --title), jq returns an empty string, producing an invalid replaces value "authorino-operator." that fails bundle validation. Use jq's alternative operator (//) to fall back to tag_name when name is empty or null. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
jq's // operator only catches null/false, not empty string "".
The original bug was an empty name (""), so the previous fix didn't
actually cover the failing case. Use an explicit length check instead.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Thomas Maas <thomas@webtypes.com>
The release workflow always created a new local branch, which failed when the release branch already existed on origin (e.g. patch releases). Check for the remote branch first and fetch/checkout it if present. Signed-off-by: Phil Brookes <pbrookes@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: Thomas Maas <thomas@webtypes.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.25 #339 +/- ##
=============================================
Coverage 57.20% 57.20%
=============================================
Files 13 13
Lines 1458 1458
=============================================
Hits 834 834
Misses 529 529
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Update RELATED_IMAGE_AUTHORINO from v0.26.1 to v0.26.2 across build config, manager, deploy manifests, Helm chart, and OLM bundle. Authorino v0.26.2 includes: - Fix OAuth2 introspection panic on non-200 responses - Fix authorization failing open on context timeout - Fix pprof port clash on status update manager - Fix UMA PAT response body resource leak - Go 1.26.3 → 1.26.4 - CI hardening (StepSecurity, CodeQL, cosigning) Signed-off-by: Thomas Maas <thomas@webtypes.com>
Run make manifests, make bundle, and make helm-build to regenerate all derived files with the correct authorino v0.26.2 image reference and updated AuthConfig CRD from synced authorino manifests. Signed-off-by: Thomas Maas <thomas@webtypes.com>
957828e to
821fcff
Compare
Summary
Cherry-picked 12 patch-safe fixes from main + authorino operand bump for a v0.25.2 release.
Authorino operand: v0.26.1 → v0.26.2 (release)
Operator fixes:
97a6459— Fix: validate bundle after all modifications completea418ca0— Fix: fall back to tag_name when release name is empty92f8667— Fix: handle empty string name in set-replaces-directivee0ddc7a— Fix: checkout existing release branch instead of failing on re-releaseToolchain: Go 1.26.3 → 1.26.4
CI: Automated Authorino manifests sync workflow + GPG signature, updated manifests (4 syncs)
Excluded (features):
e338dd0— TLS version/cipher suite CRD fields (new API surface)cfdd616— pprof bind address flag (new capability)7d108fd— USE_IMAGE_DIGESTS build flag (new build capability)Test plan
go build ./...passes