Skip to content

feat(kuadrant): read-only Gateway detail view (#369) - #381

Merged
emmaaroche merged 4 commits into
Kuadrant:mainfrom
R-Lawton:issue-369-gateway-detail-view
Sep 3, 2026
Merged

feat(kuadrant): read-only Gateway detail view (#369)#381
emmaaroche merged 4 commits into
Kuadrant:mainfrom
R-Lawton:issue-369-gateway-detail-view

Conversation

@R-Lawton

@R-Lawton R-Lawton commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Read-only detail view for the Gateway (gateway.networking.k8s.io/v1) resource, at /kuadrant/gateways/:namespace/:name. You land on it by clicking a Gateway row in the MCP overview table (#355). Closes #369.

What's here

Details tab — Name, Namespace, Ready/Status, Age, Labels, Annotations, Created at, Owner, and a Conditions table (Type, Status, Updated, Reason, Message).

YAML tab — the raw manifest, read-only, rendered with core-components CodeSnippet.

Changes

  • Backend: GET /gateways/:namespace/:name returns the full Gateway manifest (mirrors the existing /httproutes/:namespace/:name handler).
  • Frontend: kuadrantApi.getGateway(), the detail page, and the MCP Gateways table Name column now links to it.
  • Gateway manifest types centralised in types/mcp.ts.

Testing

  • Unit: GatewayDetailPage/utils.test.ts (14) + backend router.test.ts gateway-read cases (200/403/500).
  • E2E: kuadrant-gateway-detail.spec.ts clicks through from the MCP Gateways table and checks the breadcrumb, Details tab, and YAML tab.
  • yarn tsc and the above unit tests pass locally.

Definition of done

  • Unit tests
  • E2E tests (Playwright)
  • Documentation updated (docs/ui-patterns.md)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 714d5e0d-b563-42e2-82c6-2c96739926c3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@R-Lawton
R-Lawton force-pushed the issue-369-gateway-detail-view branch 3 times, most recently from 3b09d37 to 2e163d8 Compare August 24, 2026 15:09
@R-Lawton
R-Lawton marked this pull request as ready for review August 24, 2026 15:09
Comment thread plugins/kuadrant/src/components/GatewayDetailPage/GatewayDetailPage.tsx Outdated
Comment thread plugins/kuadrant/src/components/GatewayDetailPage/GatewayDetailPage.tsx Outdated
@R-Lawton
R-Lawton marked this pull request as draft August 27, 2026 12:04
@R-Lawton

Copy link
Copy Markdown
Contributor Author

Rebasing of main now that other resources have been added. Will match their style and use their existing code

@R-Lawton
R-Lawton force-pushed the issue-369-gateway-detail-view branch 2 times, most recently from 9e52647 to e6bfa6c Compare August 31, 2026 14:22
@R-Lawton
R-Lawton marked this pull request as ready for review August 31, 2026 14:23
@R-Lawton
R-Lawton requested a review from emmaaroche August 31, 2026 17:22
emmaaroche
emmaaroche previously approved these changes Aug 31, 2026
@emmaaroche

Copy link
Copy Markdown
Member

Two small consistency nits with the other two detail pages (McpGatewayExtensionDetailPage, McpServerRegistrationDetailPage):

Both nits, not blocking - approving as is.

@emmaaroche

Copy link
Copy Markdown
Member

Sorry, this will also need rebase 🙈

@Anton-Fil

Copy link
Copy Markdown
Contributor

not rebase yet ?

R-Lawton and others added 3 commits September 1, 2026 17:48
Adds a read-only Details/YAML page for Gateway
(gateway.networking.k8s.io/v1) at /kuadrant/gateways/:namespace/:name,
reached by clicking a Gateway row in the MCP overview table.

- backend: GET /gateways/:namespace/:name returns the full manifest
- frontend: kuadrantApi.getGateway() + detail page (Details + YAML tabs)
- MCP Gateways table Name column links to the detail view
- centralise Gateway manifest types in types/mcp.ts
- unit tests (utils + backend router) and Playwright e2e
- docs: read-only resource detail view pattern

Closes Kuadrant#369

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: R-Lawton <rlawton@redhat.com>
Signed-off-by: R-Lawton <rlawton@redhat.com>
Signed-off-by: R-Lawton <rlawton@redhat.com>
@R-Lawton
R-Lawton force-pushed the issue-369-gateway-detail-view branch from 7bf7ef0 to 11f0b10 Compare September 1, 2026 16:49
@R-Lawton
R-Lawton requested a review from emmaaroche September 1, 2026 16:49
Comment thread plugins/kuadrant/src/components/GatewayDetailPage/GatewayDetailPage.tsx Outdated
Comment thread plugins/kuadrant/src/components/GatewayDetailPage/GatewayDetailPage.tsx Outdated
Comment thread plugins/kuadrant/src/components/GatewayDetailPage/utils.ts Outdated
Signed-off-by: R-Lawton <rlawton@redhat.com>

@emmaaroche emmaaroche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Image

@emmaaroche
emmaaroche merged commit bd0226d into Kuadrant:main Sep 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read-only resource detail view — Gateway

3 participants