Skip to content

fix Ref mutation during render - #828

Merged
jasonmadigan merged 1 commit into
Kuadrant:mainfrom
Anton-Fil:Ref-mutation-765
Sep 2, 2026
Merged

fix Ref mutation during render#828
jasonmadigan merged 1 commit into
Kuadrant:mainfrom
Anton-Fil:Ref-mutation-765

Conversation

@Anton-Fil

Copy link
Copy Markdown
Contributor

Description

Fixes #765.

Moves the onFormChangeRef.current assignment in HTTPRouteCreatePage from the render phase into a useEffect. This prevents ref mutation during uncommitted or replayed
React renders and resolves the React Doctor no-ref-current-in-render warning.

Testing

  • yarn lint passed.

Signed-off-by: Anton-Fil <a.filkach@gmail.com>
@Anton-Fil
Anton-Fil requested a review from R-Lawton September 2, 2026 11:08
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 2306aa98-0699-4900-9c3d-5cb37d81dfc8

📥 Commits

Reviewing files that changed from the base of the PR and between 409b127 and 4520cef.

📒 Files selected for processing (1)
  • src/components/httproute/HTTPRouteCreatePage.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jasonmadigan
jasonmadigan merged commit a1b3ba8 into Kuadrant:main Sep 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTPRouteCreatePage: Ref mutation during render

3 participants