Skip to content

MULTIARCH-5995: add ppc64le support to the build - #122

Open
raja-0940 wants to merge 1 commit into
Kuadrant:mainfrom
raja-0940:main
Open

MULTIARCH-5995: add ppc64le support to the build#122
raja-0940 wants to merge 1 commit into
Kuadrant:mainfrom
raja-0940:main

Conversation

@raja-0940

@raja-0940 raja-0940 commented May 13, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

Release Notes

  • Chores
    • Added support for the ppc64le architecture in build and deployment pipelines alongside existing amd64 and arm64 platforms.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@raja-0940 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 56 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ccb6a11-b4ec-4677-84b9-fd9a77347679

📥 Commits

Reviewing files that changed from the base of the PR and between b7e1753 and 8e78e00.

📒 Files selected for processing (3)
  • .github/workflows/release.yaml
  • doc/kuadrantctl-ci-cd.md
  • scripts/plugins
📝 Walkthrough

Walkthrough

This pull request adds support for the ppc64le architecture across the kuadrantctl build and deployment pipeline. The GitHub Actions release workflow matrix is expanded to build for ppc64le in addition to amd64 and arm64. Supporting script and documentation changes ensure the plugin system and Tekton task download mechanisms correctly handle the new architecture target.

Changes

ppc64le Architecture Support

Layer / File(s) Summary
Release build matrix and plugin scripts
.github/workflows/release.yaml, scripts/plugins
The build matrix adds ppc64le to the goarch vector alongside amd64 and arm64, and the plugin binary workspace setup creates darwin-ppc64le and linux-ppc64le directories.
CI/CD documentation
doc/kuadrantctl-ci-cd.md
The Tekton task's kuadrantctl download step now maps uname -m value ppc64le to BIN_ARCH="ppc64le" in the architecture selection case statement.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 A rabbit hops through lands anew,
Where ppc64le builds run true,
From GitHub's matrix to scripts so fine,
Three little edits align in line,
Now processors vast can join the crew!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'MULTIARCH-5995: add ppc64le support to the build' directly and clearly summarises the main change across all modified files—adding ppc64le architecture support to the build process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yaml:
- Around line 19-21: Update the GitHub Actions matrix in the release workflow to
remove the unsupported darwin/ppc64le pair: keep goos and goarch as separate
lists (goos: [linux, darwin], goarch: [amd64, arm64, ppc64le]) and add an
exclude entry that explicitly excludes the combination {goos: darwin, goarch:
ppc64le}; modify the matrix keys goos and goarch and add the exclude block so
darwin/ppc64le is not built.

In `@scripts/plugins`:
- Line 117: The script currently creates a darwin-ppc64le binary directory
(mkdir -p
$TMP_DIR/binaries/{darwin-amd64,linux-amd64,darwin-arm64,linux-arm64,darwin-ppc64le,linux-ppc64le})
which is invalid for macOS; remove the darwin-ppc64le entry from the brace list
so the mkdir invocation only creates valid OS/arch combos (e.g.,
darwin-amd64,darwin-arm64,linux-amd64,linux-arm64,linux-ppc64le) and ensure the
TMP_DIR/binaries variable usage remains unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b3ab3848-1247-4b10-9705-b03294bb0ec6

📥 Commits

Reviewing files that changed from the base of the PR and between 894bace and b7e1753.

📒 Files selected for processing (3)
  • .github/workflows/release.yaml
  • doc/kuadrantctl-ci-cd.md
  • scripts/plugins

Comment thread .github/workflows/release.yaml Outdated
Comment thread scripts/plugins Outdated
Signed-off-by: Rajakumar Battula <rbattula@redhat.com>
@Boomatang

Copy link
Copy Markdown
Member

This is not as simple an update as it may seem. When building a release the a plugin for the dns-operator is also included. Currently there is no ppc64le build of that plugin. We would first need to add a build target for that plugin. See https://github.com/Kuadrant/kuadrantctl/blob/main/.github/workflows/plugins.yaml for how the plugins are included.

@raja-0940

Copy link
Copy Markdown
Author

I have added ppc64le support to the dns-operator and raised a PR for the changes. Could you please review it? Thanks.

@prb112 prb112 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants