MULTIARCH-5995: add ppc64le support to the build - #122
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request adds support for the Changesppc64le Architecture Support
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 19-21: Update the GitHub Actions matrix in the release workflow to
remove the unsupported darwin/ppc64le pair: keep goos and goarch as separate
lists (goos: [linux, darwin], goarch: [amd64, arm64, ppc64le]) and add an
exclude entry that explicitly excludes the combination {goos: darwin, goarch:
ppc64le}; modify the matrix keys goos and goarch and add the exclude block so
darwin/ppc64le is not built.
In `@scripts/plugins`:
- Line 117: The script currently creates a darwin-ppc64le binary directory
(mkdir -p
$TMP_DIR/binaries/{darwin-amd64,linux-amd64,darwin-arm64,linux-arm64,darwin-ppc64le,linux-ppc64le})
which is invalid for macOS; remove the darwin-ppc64le entry from the brace list
so the mkdir invocation only creates valid OS/arch combos (e.g.,
darwin-amd64,darwin-arm64,linux-amd64,linux-arm64,linux-ppc64le) and ensure the
TMP_DIR/binaries variable usage remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b3ab3848-1247-4b10-9705-b03294bb0ec6
📒 Files selected for processing (3)
.github/workflows/release.yamldoc/kuadrantctl-ci-cd.mdscripts/plugins
Signed-off-by: Rajakumar Battula <rbattula@redhat.com>
|
This is not as simple an update as it may seem. When building a release the a plugin for the dns-operator is also included. Currently there is no ppc64le build of that plugin. We would first need to add a build target for that plugin. See https://github.com/Kuadrant/kuadrantctl/blob/main/.github/workflows/plugins.yaml for how the plugins are included. |
|
I have added ppc64le support to the dns-operator and raised a PR for the changes. Could you please review it? Thanks. |
Summary by CodeRabbit
Release Notes
ppc64learchitecture in build and deployment pipelines alongside existingamd64andarm64platforms.