go-graphviz v0.2.10 - #123
Conversation
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
📝 WalkthroughWalkthroughThe Go module updates ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 48.39% 45.21% -3.19%
==========================================
Files 17 18 +1
Lines 998 794 -204
==========================================
- Hits 483 359 -124
+ Misses 443 363 -80
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Updates
github.com/goccy/go-graphvizfrom v0.2.9 to v0.2.10 to fix a segmentation fault in thetopologycommand.Problem
The
kuadrantctl topology --svgcommand was experiencing a segmentation fault when attempting to render topology data that contained error messages (specifically when the topology exceeds the ConfigMap 1MB limit). The crash occurred in the runtime's garbage collector during the DOT graph parsing phase.Error example:
Solution
Upgrading to go-graphviz v0.2.10 resolves the parsing issue. The library now correctly handles edge cases in DOT graph parsing that previously caused memory corruption and crashes.
Changes
github.com/goccy/go-graphvizfrom v0.2.9 to v0.2.10github.com/tetratelabs/wazerofrom v1.8.1 to v1.10.1Testing
Verified that
bin/kuadrantctl topology --svg ~/tmp/topology.svgnow:Impact
Summary by CodeRabbit