Skip to content

go-graphviz v0.2.10 - #123

Merged
eguzki merged 1 commit into
mainfrom
update-go-graphviz
Jul 14, 2026
Merged

go-graphviz v0.2.10#123
eguzki merged 1 commit into
mainfrom
update-go-graphviz

Conversation

@eguzki

@eguzki eguzki commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updates github.com/goccy/go-graphviz from v0.2.9 to v0.2.10 to fix a segmentation fault in the topology command.

Problem

The kuadrantctl topology --svg command was experiencing a segmentation fault when attempting to render topology data that contained error messages (specifically when the topology exceeds the ConfigMap 1MB limit). The crash occurred in the runtime's garbage collector during the DOT graph parsing phase.

Error example:

SIGSEGV: segmentation violation
PC=0x46ff45 m=15 sigcode=1 addr=0x110

goroutine 0 gp=0xc0001d1180 m=15 mp=0xc00051f008 [idle]:
runtime.(*unwinder).next(0x7f9cea7fbaf8)
runtime.memmove()

Solution

Upgrading to go-graphviz v0.2.10 resolves the parsing issue. The library now correctly handles edge cases in DOT graph parsing that previously caused memory corruption and crashes.

Changes

  • Updated github.com/goccy/go-graphviz from v0.2.9 to v0.2.10
  • Updated transitive dependency github.com/tetratelabs/wazero from v1.8.1 to v1.10.1

Testing

Verified that bin/kuadrantctl topology --svg ~/tmp/topology.svg now:

  • Completes successfully without segmentation fault
  • Correctly generates SVG output displaying the error message when topology exceeds ConfigMap limits
  • No longer crashes on edge case DOT graph inputs

Impact

  • Fixes critical crash that prevented users from using the topology visualization feature
  • No breaking changes or API modifications
  • Backward compatible dependency update

Summary by CodeRabbit

  • Chores
    • Updated underlying Graphviz and WebAssembly runtime components to newer versions.
    • No user-facing features or behaviour changes were introduced.

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Go module updates github.com/goccy/go-graphviz from v0.2.9 to v0.2.10 and indirect github.com/tetratelabs/wazero from v1.8.1 to v1.10.1.

Changes

Dependency updates

Layer / File(s) Summary
Module version bumps
go.mod
Updates the Graphviz and indirect Wazero dependency versions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A rabbit hops through go.mod bright,
Two packages take a newer flight.
Graphviz grows, Wazero too,
With tidy paths and versions new.
Hop, hop, done—the build looks spry!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly identifies the main change: bumping go-graphviz to v0.2.10.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-go-graphviz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eguzki
eguzki requested a review from Boomatang July 14, 2026 10:35
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.21%. Comparing base (3988d85) to head (64f0c4f).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   48.39%   45.21%   -3.19%     
==========================================
  Files          17       18       +1     
  Lines         998      794     -204     
==========================================
- Hits          483      359     -124     
+ Misses        443      363      -80     
  Partials       72       72              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Boomatang Boomatang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@eguzki
eguzki added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit f74f59b Jul 14, 2026
10 checks passed
@eguzki
eguzki deleted the update-go-graphviz branch July 14, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants