harden workflows: pin every use - #124
Conversation
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📝 WalkthroughWalkthroughDependabot is configured for weekly GitHub Actions updates. CI, command, plugin, release, and testing workflows replace floating action tags with commit-pinned revisions while preserving existing job logic and inputs. ChangesGitHub Actions dependency management
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/code-style.yaml:
- Line 38: Remove the checkout step from the required-checks aggregate jobs in
.github/workflows/code-style.yaml (lines 38-38), .github/workflows/commands.yaml
(lines 45-45), and .github/workflows/testing.yaml (lines 68-68); leave their
needs-result evaluation unchanged.
- Around line 22-23: Add persist-credentials: false to each repository-only
actions/checkout step in .github/workflows/code-style.yaml (22-23),
.github/workflows/commands.yaml (26-27), .github/workflows/plugins.yaml (35-36),
.github/workflows/release.yaml (23), and both checkout steps in
.github/workflows/testing.yaml (24-25 and 41-42); preserve any checkout
configuration and do not disable credentials where authenticated Git operations
are explicitly required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 78410ad5-38db-4000-906f-f35786c43df5
📒 Files selected for processing (6)
.github/dependabot.yml.github/workflows/code-style.yaml.github/workflows/commands.yaml.github/workflows/plugins.yaml.github/workflows/release.yaml.github/workflows/testing.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 48.39% 45.21% -3.19%
==========================================
Files 17 18 +1
Lines 998 794 -204
==========================================
- Hits 483 359 -124
+ Misses 443 363 -80
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
71d6f2d to
c776e2e
Compare
Boomatang
left a comment
There was a problem hiding this comment.
PR looks good and I would be happy to approve. There is one question that is non blocking but you might want to do it in this PR.
|
|
||
| - name: Check out code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@0717577d45739eb3c851188b29f50ed6c0b2194e # v2.8.0 |
There was a problem hiding this comment.
I don't know if you want to address it in this PR but there is there different version of the checkout action being used in five different places.
Do you want to address this in this PR?
There was a problem hiding this comment.
good catch. Let me fix that.
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Summary by CodeRabbit
Chores
Tests