Resource generation - default to yaml, add option for output formats (JSON or YAML) - #66
Merged
Merged
Conversation
jasonmadigan
force-pushed
the
generation-formats
branch
from
April 29, 2024 13:55
77d226e to
ca1d228
Compare
jasonmadigan
marked this pull request as ready for review
April 29, 2024 13:55
Member
Author
|
@maleck13 fyi: some of this might be of interest for the demo too |
jasonmadigan
force-pushed
the
generation-formats
branch
from
April 29, 2024 14:02
ca1d228 to
e54e7e0
Compare
eguzki
reviewed
Apr 30, 2024
eguzki
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Left some minor comments to discuss before approving. But this is ready to be merged.
Verification steps worked as expected. Thanks for those.
Member
Author
|
@eguzki made a few tweaks - thanks for the earlier review |
eguzki
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yaml, add option for output formats (JSON or YAML)Verify
go buildor one of the make targets