clippy::drain-collect

[adam-cattermole]

Summary by CodeRabbit

• Performance
  • Improved internal task queue handling during pipeline evaluation without changing processing behaviour.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5197f0f5-5dac-4855-802c-57d9e71bfddf

📥 Commits

Reviewing files that changed from the base of the PR and between af0f9b4 and 35b9882.

📒 Files selected for processing (1)

• crates/kuadrant-filter/src/kuadrant/pipeline/executor.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Pipeline::eval now uses std::mem::take to transfer ownership of the task queue. Task processing remains unchanged.

Changes

Pipeline evaluation

Layer / File(s)	Summary
Task queue transfer crates/kuadrant-filter/src/kuadrant/pipeline/executor.rs	Pipeline::eval takes ownership of task_queue with std::mem::take instead of draining and collecting it. Subsequent task processing is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 35b98

This is a narrowly scoped code change, and no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the task queue bright,
take moves the tasks with care,
No drain, no collect,
The work proceeds as before,
And hops away light as air.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the clippy lint addressed by replacing drain-collect behaviour with std::mem::take.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch clippy-lints

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Boomatang]

Tests are passing and the change follows the recommendation in https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#drain_collect